You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/04/06 17:29:13 UTC
[PR] HDDS-12775. flaky-test-check builds the workflow branch [ozone]
adoroszlai opened a new pull request, #8237:
URL: https://github.com/apache/ozone/pull/8237
## What changes were proposed in this pull request?
`flaky-test-check` has input for the Git ref to test, but its `build` job checks out the branch given in "Use workflow from". This can cause test failure, e.g. if Ozone version is different on the two branches.
```
Reset branch 'master'
branch 'master' set up to track 'origin/master'.
```
https://github.com/adoroszlai/ozone/actions/runs/14294769454/job/40060575305#step:2:73
https://issues.apache.org/jira/browse/HDDS-12775
## How was this patch tested?
```
Switched to a new branch 'flaky-test-check-debug'
branch 'flaky-test-check-debug' set up to track 'origin/flaky-test-check-debug'.
```
https://github.com/adoroszlai/ozone/actions/runs/14294864376/job/40060779727#step:2:77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12775. flaky-test-check builds the workflow branch [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8237:
URL: https://github.com/apache/ozone/pull/8237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12775. flaky-test-check builds the workflow branch [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #8237:
URL: https://github.com/apache/ozone/pull/8237#discussion_r2031669721
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -147,6 +147,8 @@ jobs:
steps:
- name: Checkout project
uses: actions/checkout@v4
+ with:
+ ref: ${{ github.event.inputs.ref }}
Review Comment:
Since the run-test job uses the right ref, the issue occurs only when build and test versions are far apart I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12775. flaky-test-check builds the workflow branch [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8237:
URL: https://github.com/apache/ozone/pull/8237#discussion_r2031680622
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -147,6 +147,8 @@ jobs:
steps:
- name: Checkout project
uses: actions/checkout@v4
+ with:
+ ref: ${{ github.event.inputs.ref }}
Review Comment:
Yes, that's how we found it, since recently version was bumped to `2.1.0-SNAPSHOT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12775. flaky-test-check builds the workflow branch [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8237:
URL: https://github.com/apache/ozone/pull/8237#issuecomment-2784059869
Thanks @peterxcli, @sadanand48 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org