You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2023/02/28 17:24:42 UTC

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1448576594

   I removed the checkstyle statements which allow `connect-runtime` to import `tools`. Since this is the only dependency on `tools`, we also have an opportunity to disallow _any_ importing of the tools package, similar to the kafka server.
   
   Is this a good idea? Does it make sense for the `tools` package to disallow everyone from importing it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org