You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/04 20:03:18 UTC
[GitHub] [fineract] shreyas-s-k opened a new pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
shreyas-s-k opened a new pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
## Description
There is an erratic behaviour when the transfer job runs and transfers posted interest in a backdated FD account to a linked savings account.
This happens especially when Interest posting is set to be in the end of period.
(https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [
x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961673237
@avikganguly01 (cc @awasum )
We have all agreed to a common way of dealing with flaky tests, as discussed on the mailing list and documented here: https://github.com/apache/fineract#pull-requests
It's rather disappointing that a prominent member of the community such as yourself is ignoring the agreed community guidelines, and independently rewriting the rules as you see fit.
If you'd like to propose a different way of dealing with failing tests, perhaps you could propose it on the mailing list and get agreement around the new rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961669013
@ptuomola (cc @awasum @fynmanoj @vidakovic ):
Please find 2 new additions to the list of flaky tests :-
testCenterReschedulingLoansWithInterestRecalculationEnabled
testCenterReschedulingMultiTrancheLoansWithInterestRecalculationEnabled
Merging the PR as it's not the committer's responsibility to get a proposed PR to pass the build when there are 25+ flaky tests. Committer has checked with gradle test command that all non flaky tests are passing.
The data points you are referring to in the other thread to deny the existence of flaky tests is not valid as they are manipulated.
Perhaps a way of not stepping on each other's feet is to separate the services as you were discussing with Aleksander. I think Batch API module is a good place to start as it's already decoupled at the service and domain layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961406417
Lets give this sometime before Travis can run..Or maybe in time the new Github Actions based CI in https://github.com/apache/fineract/pull/1955 will already be in place to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961586188
One test case failed on Travis
Test testLoanImport() FAILED (19.2s)
@shreyas-s-k , please retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961669013
@ptuomola (cc @awasum @fynmanoj @vidakovic ):
Please find 2 new additions to the list of flaky tests :-
testCenterReschedulingLoansWithInterestRecalculationEnabled
testCenterReschedulingMultiTrancheLoansWithInterestRecalculationEnabled
Merging the PR as it's not the committer's responsibility to get a proposed PR to pass the build when there are 25+ flaky tests. Committer has checked with gradle test command that all non flaky tests are passing.
The data points you are referring to in the other thread to deny the existence of flaky tests is not valid as they are manipulated.
Perhaps a way of not stepping on each other's feet is to separate the services as you were discussing with Aleksander. I think Batch API module is a good place to start as it's already decoupled at the service and domain layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961715352
@avikganguly01 (cc @awasum @fynmanoj @vidakovic)
Just like last time, I've debugged your "flaky test".
Yet again, there was nothing flaky about this.
The test is broken by PR #1917 that was merged by you earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961406417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961586188
One test case failed on Travis
Test testLoanImport() FAILED (19.2s)
@shreyas-s-k , please retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961412912
Trying to Trigger Travis build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961669013
@ptuomola (cc @awasum @fynmanoj @vidakovic ):
Please find 2 new additions to the list of flaky tests :-
testCenterReschedulingLoansWithInterestRecalculationEnabled
testCenterReschedulingMultiTrancheLoansWithInterestRecalculationEnabled
Merging the PR as it's not the committer's responsibility to get a proposed PR to pass the build when there are 25+ flaky tests. Committer has checked with gradle test command that all non flaky tests are passing.
The data points you are referring to in the other thread to deny the existence of flaky tests is not valid as they are manipulated.
Perhaps a way of not stepping on each other's feet is to separate the services as you were discussing with Aleksander. I think Batch API module is a good place to start as it's already decoupled at the service and domain layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-962390348
I have now fixed the issue introduced by PR #1917 and the "flaky" tests (as you called them) are now passing again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961673237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961673237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1956:
URL: https://github.com/apache/fineract/pull/1956#issuecomment-961586188
One test case failed on Travis
Test testLoanImport() FAILED (19.2s)
@shreyas-s-k , please retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1956: FINERACT-1429 : FD Interest Transfer on a backdated account
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1956:
URL: https://github.com/apache/fineract/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org