You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "hoey94 (via GitHub)" <gi...@apache.org> on 2023/07/12 07:14:44 UTC
[GitHub] [dolphinscheduler] hoey94 opened a new pull request, #14516: fix Get dqRules entry failed in postgres database (#14515)
hoey94 opened a new pull request, #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516
I removed the character ` in the development environment and retried, and verified that there is no problem in the postgres15.3 environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] qingwli commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632081263
Hi @hoey94 , I saw you another commit https://github.com/apache/dolphinscheduler/commit/273c26df08ad4112e2a3158b7549ed3a8a832303, and why delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 closed pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 closed pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
URL: https://github.com/apache/dolphinscheduler/pull/14516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632091889
Hello. Thank you for your reply.
I have submitted two issues.
https://github.com/apache/dolphinscheduler/issues/14515
https://github.com/apache/dolphinscheduler/issues/14517
I think we can put them together and fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] qingwli commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632153862
`Add ;NON_KEYWORDS=value to the url` Will works but In my option is not a good idea. The field name use database keyword is not well, we better solve this issue at the source. WDYT @SbloodyS @zixi0825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632138878
I checked the git commit history of the "value" field and found that a correction was made in https://github.com/apache/dolphinscheduler/pull/12781 issue to adapt to the H2 Database.
I checked the H2 operation manual and it can be corrected in the following two ways
1. Add `` to the field
2. Add ;NON_KEYWORDS=value to the url
I thought about it and used the following solution to fix this problem https://github.com/apache/dolphinscheduler/issues/14515
1. Add ;NON_KEYWORDS=value to the url
2. Remove ``
Hi @qingwli . Can you help me to make sure if this is a good way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632081101
> Thank you for your reply. May I ask you a question, is it necessary to add [Fix-#issue_id] when doing git commit, eg: git commit -s -m “[Fix-14515] Get dqRules entry failed in postgres database”
It's not necessary. But it's better to do that in the PR's title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #14516: fix Get dqRules entry failed in postgres database
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632065750
> Hello. How to link PR to issue? issue links: #14515
To target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.
I have corrected your description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632077986
Thank you for your reply. May I ask you a question, is it necessary to add [Fix-#issue_id] when doing git commit, eg:
git commit -s -m “[Fix-14515] Get dqRules entry failed in postgres database”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] qingwli commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632116035
@hoey94 Yeah, I think you can put them in a pr.
And for this `value` field, for mysql needs add `` but for pg we can just use it or add `""`.
So just remove `` is not a good way. Maybe you should change this field name for this table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632056877
how to link this PR to your issue?
issue links: https://github.com/apache/dolphinscheduler/issues/14515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632177326
Modifying the value field with a new name is advisable. The usage of database keywords can lead to various issues. Furthermore, evaluating the extent of impact is crucial when making changes to a database field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hoey94 commented on pull request #14516: [Fix-14515]fix Get dqRules entry failed in postgres database
Posted by "hoey94 (via GitHub)" <gi...@apache.org>.
hoey94 commented on PR #14516:
URL: https://github.com/apache/dolphinscheduler/pull/14516#issuecomment-1632237584
Hi @SbloodyS @zixi0825 @qingwli
I have made the necessary adjustments to the code as instructed.
1. Add ;NON_KEYWORDS=value to the url
2. Remove ``
If deemed feasible, I will proceed to resubmit the PR on my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org