[GitHub] jeffreythewang opened a new pull request #5388: Move VIZ_TYPES to separate module

[GitBox <gi...@apache.org>]

jeffreythewang opened a new pull request #5388: Move VIZ_TYPES to separate module
URL: https://github.com/apache/incubator-superset/pull/5388
 
 
   Since we are importing `nvd3Vis`, in `superset/assets/src/visualizations/index.js`, I think it makes sense to separate `VIZ_TYPES` to avoid circular dependencies. (Importing `VIZ_TYPES` would import `nvd3_vis.js`, which imports `AnnotationTypes`, which imports `VIZ_TYPES`). Feel free to suggest a different file name.
   
   re: lint errors - will rebase when master is updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org