You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2019/11/03 17:54:33 UTC
[thrift] branch master updated (ec43954 -> 1ce7317)
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git.
from ec43954 THRIFT-4990 Switch to .NET core 3.0 Client: netstsd Patch: Jens Geyer
new 43a93f1 fix typo in cmake Patch: Jens Geyer
new bc75467 Fix "thruth" typo Client: Go Patch: Kevin Wojniak
new cf73b66 Remove unused exception variable Client: Python Patch: Kevin Wojniak
new 1ce7317 Replace unknown BUILD_THRIFT variable Patch: Kevin Wojniak
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
build/cmake/DefineOptions.cmake | 2 +-
lib/go/thrift/http_client.go | 2 +-
lib/go/thrift/iostream_transport.go | 2 +-
lib/go/thrift/ssl_socket.go | 2 +-
lib/hs/CMakeLists.txt | 2 +-
lib/py/src/ext/protocol.tcc | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
[thrift] 04/04: Replace unknown BUILD_THRIFT variable Patch: Kevin
Wojniak
Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
commit 1ce7317cae2c580ded065db6dad54647e96d3359
Author: Kevin Wojniak <ka...@users.noreply.github.com>
AuthorDate: Sun Nov 3 00:26:55 2019 -0700
Replace unknown BUILD_THRIFT variable
Patch: Kevin Wojniak
This closes #1914
It should be BUILD_COMPILER. There are no other references to BUILD_THRIFT in the repo.
---
build/cmake/DefineOptions.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build/cmake/DefineOptions.cmake b/build/cmake/DefineOptions.cmake
index 778be8d..6a69c6d 100644
--- a/build/cmake/DefineOptions.cmake
+++ b/build/cmake/DefineOptions.cmake
@@ -151,7 +151,7 @@ message(STATUS "Build configuration summary")
message(STATUS " Build compiler: ${BUILD_COMPILER}")
message(STATUS " Build libraries: ${BUILD_LIBRARIES}")
message(STATUS " Build tests: ${BUILD_TESTING}")
-MESSAGE_DEP(HAVE_COMPILER "Disabled because BUILD_THRIFT=OFF and no valid THRIFT_COMPILER is given")
+MESSAGE_DEP(HAVE_COMPILER "Disabled because BUILD_COMPILER=OFF and no valid THRIFT_COMPILER is given")
message(STATUS " Build type: ${CMAKE_BUILD_TYPE}")
message(STATUS)
message(STATUS "Language libraries:")
[thrift] 02/04: Fix "thruth" typo Client: Go Patch: Kevin Wojniak
Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
commit bc75467e4426c76d201c83621f08fa211660b6c3
Author: Kevin Wojniak <ka...@users.noreply.github.com>
AuthorDate: Sat Nov 2 21:13:34 2019 -0700
Fix "thruth" typo
Client: Go
Patch: Kevin Wojniak
This closes #1911
---
lib/go/thrift/http_client.go | 2 +-
lib/go/thrift/iostream_transport.go | 2 +-
lib/go/thrift/ssl_socket.go | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/go/thrift/http_client.go b/lib/go/thrift/http_client.go
index 5c82bf5..d093eeb 100644
--- a/lib/go/thrift/http_client.go
+++ b/lib/go/thrift/http_client.go
@@ -218,7 +218,7 @@ func (p *THttpClient) RemainingBytes() (num_bytes uint64) {
}
const maxSize = ^uint64(0)
- return maxSize // the thruth is, we just don't know unless framed is used
+ return maxSize // the truth is, we just don't know unless framed is used
}
// Deprecated: Use NewTHttpClientTransportFactory instead.
diff --git a/lib/go/thrift/iostream_transport.go b/lib/go/thrift/iostream_transport.go
index fea93bc..0b1775d 100644
--- a/lib/go/thrift/iostream_transport.go
+++ b/lib/go/thrift/iostream_transport.go
@@ -210,5 +210,5 @@ func (p *StreamTransport) WriteString(s string) (n int, err error) {
func (p *StreamTransport) RemainingBytes() (num_bytes uint64) {
const maxSize = ^uint64(0)
- return maxSize // the thruth is, we just don't know unless framed is used
+ return maxSize // the truth is, we just don't know unless framed is used
}
diff --git a/lib/go/thrift/ssl_socket.go b/lib/go/thrift/ssl_socket.go
index ba63377..45bf38a 100644
--- a/lib/go/thrift/ssl_socket.go
+++ b/lib/go/thrift/ssl_socket.go
@@ -172,5 +172,5 @@ func (p *TSSLSocket) Interrupt() error {
func (p *TSSLSocket) RemainingBytes() (num_bytes uint64) {
const maxSize = ^uint64(0)
- return maxSize // the thruth is, we just don't know unless framed is used
+ return maxSize // the truth is, we just don't know unless framed is used
}
[thrift] 01/04: fix typo in cmake Patch: Jens Geyer
Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
commit 43a93f1e6e7bc0d4247c8fe40c99cdcb8123b334
Author: Jens Geyer <je...@apache.org>
AuthorDate: Sat Nov 2 23:21:14 2019 +0100
fix typo in cmake
Patch: Jens Geyer
This closes #1910
---
lib/hs/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/hs/CMakeLists.txt b/lib/hs/CMakeLists.txt
index 1a5b8fd..c477c9b 100644
--- a/lib/hs/CMakeLists.txt
+++ b/lib/hs/CMakeLists.txt
@@ -37,7 +37,7 @@ set(haskell_sources
)
if(BUILD_TESTING)
- list(APPEND haskell_soruces
+ list(APPEND haskell_sources
test/Spec.hs
test/BinarySpec.hs
test/CompactSpec.hs
[thrift] 03/04: Remove unused exception variable Client: Python
Patch: Kevin Wojniak
Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
commit cf73b66cd83e2e883d00dff518d3c0250bb839cc
Author: Kevin Wojniak <ka...@users.noreply.github.com>
AuthorDate: Sat Nov 2 22:01:56 2019 -0700
Remove unused exception variable
Client: Python
Patch: Kevin Wojniak
This closes #1912
Fixes MSVC warning seen in logs:
> [00:11:03] src\ext/protocol.tcc(177): warning C4101: 'ex': unreferenced
> local variable [C:\projects\build\MSVC2015\x86\lib\py\python_build.vcxproj]
---
lib/py/src/ext/protocol.tcc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/py/src/ext/protocol.tcc b/lib/py/src/ext/protocol.tcc
index e15df7e..ede2bb4 100644
--- a/lib/py/src/ext/protocol.tcc
+++ b/lib/py/src/ext/protocol.tcc
@@ -174,7 +174,7 @@ inline bool ProtocolBase<Impl>::writeBuffer(char* data, size_t size) {
if (output_->buf.capacity() < need) {
try {
output_->buf.reserve(need);
- } catch (std::bad_alloc& ex) {
+ } catch (std::bad_alloc&) {
PyErr_SetString(PyExc_MemoryError, "Failed to allocate write buffer");
return false;
}