You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jesse Wilson (JIRA)" <ji...@apache.org> on 2009/12/01 02:07:21 UTC
[jira] Created: (HARMONY-6396) Several null handling bugs in
collections
Several null handling bugs in collections
-----------------------------------------
Key: HARMONY-6396
URL: https://issues.apache.org/jira/browse/HARMONY-6396
Project: Harmony
Issue Type: Bug
Components: JDK
Environment: SVN Revision: 882389
Reporter: Jesse Wilson
Assignee: Jesse Wilson
Attachments: Fixes_for_nullness_bugs_in_java_util.patch
I've attached a patch for various correctness issues in our collections:
- Maps with null values used to think they were equal to every other map with the same size.
- Map.equals() and Set.equals() didn't recover from NPEs in contains().
- singletonMap()'s entry didn't implement toString().
- TreeMaps with natural ordering permitted a null element, if it was the first element ever added.
- TreeSets didn't return the right status messages on add() and remove() when nulls were in play.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6396) Several null handling bugs in
collections
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson closed HARMONY-6396.
---------------------------------
Resolution: Fixed
Fixed with r888668
> Several null handling bugs in collections
> -----------------------------------------
>
> Key: HARMONY-6396
> URL: https://issues.apache.org/jira/browse/HARMONY-6396
> Project: Harmony
> Issue Type: Bug
> Components: JDK
> Environment: SVN Revision: 882389
> Reporter: Jesse Wilson
> Assignee: Jesse Wilson
> Attachments: Fixes_for_nullness_bugs_in_java_util.patch, Fixes_for_nullness_bugs_in_java_util_2.patch
>
>
> I've attached a patch for various correctness issues in our collections:
> - Maps with null values used to think they were equal to every other map with the same size.
> - Map.equals() and Set.equals() didn't recover from NPEs in contains().
> - singletonMap()'s entry didn't implement toString().
> - TreeMaps with natural ordering permitted a null element, if it was the first element ever added.
> - TreeSets didn't return the right status messages on add() and remove() when nulls were in play.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6396) Several null handling bugs in
collections
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787895#action_12787895 ]
Hudson commented on HARMONY-6396:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #580 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/580/])
Fix for ; Null handling bugs in collections.
> Several null handling bugs in collections
> -----------------------------------------
>
> Key: HARMONY-6396
> URL: https://issues.apache.org/jira/browse/HARMONY-6396
> Project: Harmony
> Issue Type: Bug
> Components: JDK
> Environment: SVN Revision: 882389
> Reporter: Jesse Wilson
> Assignee: Jesse Wilson
> Attachments: Fixes_for_nullness_bugs_in_java_util.patch, Fixes_for_nullness_bugs_in_java_util_2.patch
>
>
> I've attached a patch for various correctness issues in our collections:
> - Maps with null values used to think they were equal to every other map with the same size.
> - Map.equals() and Set.equals() didn't recover from NPEs in contains().
> - singletonMap()'s entry didn't implement toString().
> - TreeMaps with natural ordering permitted a null element, if it was the first element ever added.
> - TreeSets didn't return the right status messages on add() and remove() when nulls were in play.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6396) Several null handling bugs in
collections
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6396:
----------------------------------
Attachment: Fixes_for_nullness_bugs_in_java_util_2.patch
I've revised the patch to include fixes for these additional problems:
- Fixing equals and identity equality problems for reverse comparators
- Fixing Collections.min() and Collections.max() to work with a null comparator
- Changing checked collections to permit null. This behaviour is also broken in RI 1.5 and 1.6. The patch makes us consistent with OpenJDK 1.6.
- Changing checked collections to make addAll() fail atomically.
> Several null handling bugs in collections
> -----------------------------------------
>
> Key: HARMONY-6396
> URL: https://issues.apache.org/jira/browse/HARMONY-6396
> Project: Harmony
> Issue Type: Bug
> Components: JDK
> Environment: SVN Revision: 882389
> Reporter: Jesse Wilson
> Assignee: Jesse Wilson
> Attachments: Fixes_for_nullness_bugs_in_java_util.patch, Fixes_for_nullness_bugs_in_java_util_2.patch
>
>
> I've attached a patch for various correctness issues in our collections:
> - Maps with null values used to think they were equal to every other map with the same size.
> - Map.equals() and Set.equals() didn't recover from NPEs in contains().
> - singletonMap()'s entry didn't implement toString().
> - TreeMaps with natural ordering permitted a null element, if it was the first element ever added.
> - TreeSets didn't return the right status messages on add() and remove() when nulls were in play.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6396) Several null handling bugs in
collections
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6396:
----------------------------------
Attachment: Fixes_for_nullness_bugs_in_java_util.patch
> Several null handling bugs in collections
> -----------------------------------------
>
> Key: HARMONY-6396
> URL: https://issues.apache.org/jira/browse/HARMONY-6396
> Project: Harmony
> Issue Type: Bug
> Components: JDK
> Environment: SVN Revision: 882389
> Reporter: Jesse Wilson
> Assignee: Jesse Wilson
> Attachments: Fixes_for_nullness_bugs_in_java_util.patch
>
>
> I've attached a patch for various correctness issues in our collections:
> - Maps with null values used to think they were equal to every other map with the same size.
> - Map.equals() and Set.equals() didn't recover from NPEs in contains().
> - singletonMap()'s entry didn't implement toString().
> - TreeMaps with natural ordering permitted a null element, if it was the first element ever added.
> - TreeSets didn't return the right status messages on add() and remove() when nulls were in play.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.