You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2025/07/12 06:12:52 UTC
[PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
slfan1989 opened a new pull request, #7800:
URL: https://github.com/apache/hadoop/pull/7800
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
JIRA: HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException.
In JUnit 4, org.junit.internal.AssumptionViolatedException is used to indicate assumption failure and skip the test. However, AssumptionViolatedException is an implementation in JUnit 4, and in JUnit 5, we can use TestAbortedException to replace AssumptionViolatedException.
TestAbortedException is used to indicate that a test has been aborted, and it can be used to replace AssumptionViolatedException. However, it is not directly related to assumption failure and is more commonly used in situations where the test needs to be aborted during execution.
### How was this patch tested?
Junit Test.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3100172626
@steveloughran @cnauroth I plan to merge this PR first to continue advancing the upgrade of other JUnit5 unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3065373842
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 12 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 5m 48s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 38m 26s | | trunk passed |
| +1 :green_heart: | compile | 18m 10s | | trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 15m 28s | | trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| +1 :green_heart: | checkstyle | 4m 41s | | trunk passed |
| +1 :green_heart: | mvnsite | 7m 20s | | trunk passed |
| +1 :green_heart: | javadoc | 6m 33s | | trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 6m 15s | | trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| +1 :green_heart: | spotbugs | 11m 22s | | trunk passed |
| +1 :green_heart: | shadedclient | 42m 23s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 12s | | the patch passed |
| +1 :green_heart: | compile | 17m 14s | | the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 17m 14s | | the patch passed |
| +1 :green_heart: | compile | 15m 24s | | the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| +1 :green_heart: | javac | 15m 24s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 4m 44s | | the patch passed |
| +1 :green_heart: | mvnsite | 7m 13s | | the patch passed |
| +1 :green_heart: | javadoc | 6m 30s | | the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 6m 16s | | the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| +1 :green_heart: | spotbugs | 12m 36s | | the patch passed |
| +1 :green_heart: | shadedclient | 43m 18s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 22m 53s | | hadoop-common in the patch passed. |
| +1 :green_heart: | unit | 104m 3s | | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | unit | 3m 53s | | hadoop-aws in the patch passed. |
| +1 :green_heart: | unit | 3m 7s | | hadoop-azure in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | | hadoop-aliyun in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | | hadoop-cos in the patch passed. |
| +1 :green_heart: | unit | 0m 46s | | hadoop-huaweicloud in the patch passed. |
| +1 :green_heart: | asflicense | 1m 10s | | The patch does not generate ASF License warnings. |
| | | 419m 4s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/7800 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux ca7de1a90d3f 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 717ce8af91220c2dd9d28d3bdea477758df8ff5a |
| Default Java | Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/testReport/ |
| Max. process+thread count | 1894 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-tools/hadoop-aliyun hadoop-cloud-storage-project/hadoop-cos hadoop-cloud-storage-project/hadoop-huaweicloud U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 merged PR #7800:
URL: https://github.com/apache/hadoop/pull/7800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3081967117
@steveloughran Thank you for your message — I fully agree with your perspective. From a long-term standpoint, we do need to plan the overall testing strategy of the project more systematically, building a more robust assertion framework around AssertJ and fully leveraging the advanced features provided by JUnit 5. At present, removing the dependency on JUnit 4 is likely a more pressing priority. I’ve initiated a discussion covering several topics, including the removal of JDK 8 support, deprecation of compatibility with end-of-life (EOL) operating systems, and future support for JDK 17. I will make sure to include your suggestions as part of this discussion.
Looking forward to your response.
cc: @cnauroth @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3081977300
In our offline discussions, @pan3793 Pan has offered me a lot of valuable suggestions. I believe he has many insightful ideas that could greatly benefit the project's development — for example, adopting GitHub Workflows for unit testing, which is already widely used in projects like Flink, Ozone, and Ratis.
That said, I’ve decided to stay focused on the current priorities. My goal is to complete the preparation work for JDK 17 support on the trunk branch in Q3, and to collaborate with the @cnauroth to release the new 3.5.0 version in Q4.
Hope everything goes smoothly for all of us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3073077786
maybe we should create our own exceptions for assumption failures, aborted, timed out and use in our code; they could be subclasses of the JUnit equivalent, but give us a bit more independence in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. [hadoop]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3066745277
@cnauroth Could you help review this PR? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org