[incubator-eventmesh] branch master updated: fix issue2774

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new c0c0662d7 fix issue2774
     new 7415104ba Merge pull request #2775 from jonyangx/issue2774
c0c0662d7 is described below

commit c0c0662d76764e6ee0a7f958f9d5dcea72f23d60
Author: jonyangx <ya...@gmail.com>
AuthorDate: Sun Jan 1 10:21:43 2023 +0800

    fix issue2774
---
 .../core/consumergroup/ConsumerGroupTopicConf.java | 24 ++++++++++++----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ConsumerGroupTopicConf.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ConsumerGroupTopicConf.java
index 1bc73e1b2..4b1a9c7fb 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ConsumerGroupTopicConf.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ConsumerGroupTopicConf.java
@@ -33,7 +33,9 @@ import com.google.common.collect.Sets;
 
 public class ConsumerGroupTopicConf implements Serializable {
 
-    public static Logger logger = LoggerFactory.getLogger(ConsumerGroupTopicConf.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ConsumerGroupTopicConf.class);
+
+    private static final long serialVersionUID = 4548889791666411923L;
 
     private String consumerGroup;
 
@@ -58,17 +60,17 @@ public class ConsumerGroupTopicConf implements Serializable {
     /**
      * url auth type
      */
-    private Map<String, String> httpAuthTypeMap = Maps.newConcurrentMap();
+    private final Map<String, String> httpAuthTypeMap = Maps.newConcurrentMap();
 
     @Override
-    public boolean equals(Object o) {
+    public boolean equals(final Object o) {
         if (this == o) {
             return true;
         }
         if (o == null || getClass() != o.getClass()) {
             return false;
         }
-        ConsumerGroupTopicConf that = (ConsumerGroupTopicConf) o;
+        final ConsumerGroupTopicConf that = (ConsumerGroupTopicConf) o;
         return consumerGroup.equals(that.consumerGroup)
                 &&
                 Objects.equals(topic, that.topic)
@@ -85,11 +87,11 @@ public class ConsumerGroupTopicConf implements Serializable {
 
     @Override
     public String toString() {
-        StringBuilder sb = new StringBuilder();
+        final StringBuilder sb = new StringBuilder(120);
         sb.append("consumeTopicConfig={consumerGroup=").append(consumerGroup)
                 .append(",topic=").append(topic)
                 .append(",subscriptionMode=").append(subscriptionItem)
-                .append(",idcUrls=").append(idcUrls).append("}");
+                .append(",idcUrls=").append(idcUrls).append('}');
         return sb.toString();
     }
 
@@ -97,7 +99,7 @@ public class ConsumerGroupTopicConf implements Serializable {
         return consumerGroup;
     }
 
-    public void setConsumerGroup(String consumerGroup) {
+    public void setConsumerGroup(final String consumerGroup) {
         this.consumerGroup = consumerGroup;
     }
 
@@ -105,7 +107,7 @@ public class ConsumerGroupTopicConf implements Serializable {
         return topic;
     }
 
-    public void setTopic(String topic) {
+    public void setTopic(final String topic) {
         this.topic = topic;
     }
 
@@ -113,7 +115,7 @@ public class ConsumerGroupTopicConf implements Serializable {
         return subscriptionItem;
     }
 
-    public void setSubscriptionItem(SubscriptionItem subscriptionItem) {
+    public void setSubscriptionItem(final SubscriptionItem subscriptionItem) {
         this.subscriptionItem = subscriptionItem;
     }
 
@@ -121,7 +123,7 @@ public class ConsumerGroupTopicConf implements Serializable {
         return idcUrls;
     }
 
-    public void setIdcUrls(Map<String, List<String>> idcUrls) {
+    public void setIdcUrls(final Map<String, List<String>> idcUrls) {
         this.idcUrls = idcUrls;
     }
 
@@ -129,7 +131,7 @@ public class ConsumerGroupTopicConf implements Serializable {
         return urls;
     }
 
-    public void setUrls(Set<String> urls) {
+    public void setUrls(final Set<String> urls) {
         this.urls = urls;
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org