You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mattitoo (via GitHub)" <gi...@apache.org> on 2023/06/14 07:38:44 UTC

[GitHub] [superset] mattitoo commented on issue #24271: [SIP-96] Proposal for adding a notification feature

mattitoo commented on issue #24271:
URL: https://github.com/apache/superset/issues/24271#issuecomment-1590645620

   How we could continue on this:
   - We need to do some refactoring of the existing code to make it nicer and more accessible
   - While doing that, we would also check the HTML sanitization
   - We create a PR to have the code checked etc
   - After merging, whoever wants can work on expanding the functionality (like different types of notifications)
   The reasoning is that the topic is already big in my opinion and maybe we should add additional complexity step by step.
   Of course, I am open to other way of going forward as well, but the first 3 points are pretty clear ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org