You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/02 17:19:12 UTC

[GitHub] srowen commented on a change in pull request #23935: [SPARK-27029][BUILD] Update Thrift to 0.12.0

srowen commented on a change in pull request #23935: [SPARK-27029][BUILD] Update Thrift to 0.12.0
URL: https://github.com/apache/spark/pull/23935#discussion_r261834393
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -179,7 +179,6 @@
     <joda.version>2.9.3</joda.version>
     <jodd.version>3.5.2</jodd.version>
     <jsr305.version>3.0.0</jsr305.version>
-    <libthrift.version>0.9.3</libthrift.version>
 
 Review comment:
   Sure that's fine. Normally I'd say it's just complicating the build but it also gives others a hook to change this version without maintaining a modification to the build file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org