You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2013/10/31 19:09:02 UTC

Review Request 15139: Make tests in TestURIPermissions more restrictive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15139/
-----------------------------------------------------------

Review request for sentry, Brock Noland and Shreepadma Venugopalan.


Bugs: SENTRY-57
    https://issues.apache.org/jira/browse/SENTRY-57


Repository: sentry


Description
-------

Some minor improvements
- Fix the role names: for example role "server=server1->db=" + dbName + "->table=" + tabName + "->action=INSERT" should not be named db1_write, instead it should be "tab1_write"
- Make the positive tests permissions more restrictive. For example, if a select permission on URI is required for a command. Make sure to give SELECT instead of ALL.
- Also add a test case to external table which exposes SENTRY-56
- Comment each test with the command and permissions required, so that we can directly create documentation from here.


Diffs
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 66841146155b81245d147cb8994bc4269b9dddfd 

Diff: https://reviews.apache.org/r/15139/diff/


Testing
-------

Yes


Thanks,

Sravya Tirukkovalur

Re: Review Request 15139: Make tests in TestURIPermissions more restrictive

Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15139/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 8:46 p.m.)


Review request for sentry, Brock Noland and Shreepadma Venugopalan.


Changes
-------

Will add the test case which exposes SENTRY-56 separately, removing it here.


Bugs: SENTRY-57
    https://issues.apache.org/jira/browse/SENTRY-57


Repository: sentry


Description (updated)
-------

Some minor improvements
- Fix the role names: for example role "server=server1->db=" + dbName + "->table=" + tabName + "->action=INSERT" should not be named db1_write, instead it should be "tab1_write"
- Make the positive tests permissions more restrictive. For example, if a select permission on URI is required for a command. Make sure to give SELECT instead of ALL.
- Comment each test with the command and permissions required, so that we can directly create documentation from here.


Diffs (updated)
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 66841146155b81245d147cb8994bc4269b9dddfd 

Diff: https://reviews.apache.org/r/15139/diff/


Testing
-------

Yes


Thanks,

Sravya Tirukkovalur