[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6527: [built-in function] add greatest() and least() SQL functions

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6527:
URL: https://github.com/apache/arrow-datafusion/pull/6527#discussion_r1214563688


##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -200,6 +200,14 @@ async fn binary_bitwise_shift() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn test_comparison_func_expressions() -> Result<()> {

Review Comment:
   cool, those funcs were in my list, thanks for taking this. 
   please add more test scenariuos? with nulls, different datatypes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org