You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 11:49:46 UTC

[GitHub] [spark] LuciferYang commented on pull request #30353: [WIP][SPARK-33431][CORE][SQL][DSTREAM] Use Option.contains instead of instanceOfOption == Some(x)

LuciferYang commented on pull request #30353:
URL: https://github.com/apache/spark/pull/30353#issuecomment-726721882


   > Anyway, the changes sound reasonable. The other sub-modules (e.g., mllib) do not have the pattern (option == Some(x))?
   
   @maropu  After Address e95295a, other related issues all in the test code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org