You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/02/07 20:54:29 UTC

[kudu-CR] subprocess: add an optional sleep to Echo service 

Hello Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15184

to review the following change.


Change subject: subprocess: add an optional sleep to Echo service
......................................................................

subprocess: add an optional sleep to Echo service

I found this pretty helpful in testing the C++ subprocess.

Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
---
M java/kudu-subprocess-echo/src/main/java/org/apache/kudu/subprocess/echo/EchoProtocolHandler.java
M src/kudu/subprocess/subprocess.proto
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/15184/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] subprocess: add an optional sleep to Echo service

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15184 )

Change subject: subprocess: add an optional sleep to Echo service
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2020 05:51:53 +0000
Gerrit-HasComments: No

[kudu-CR] subprocess: add an optional sleep to Echo service

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15184 )

Change subject: subprocess: add an optional sleep to Echo service
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Feb 2020 19:58:54 +0000
Gerrit-HasComments: No

[kudu-CR] subprocess: add an optional sleep to Echo service

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15184 )

Change subject: subprocess: add an optional sleep to Echo service
......................................................................

subprocess: add an optional sleep to Echo service

I found this pretty helpful in testing the C++ subprocess.

Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
Reviewed-on: http://gerrit.cloudera.org:8080/15184
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-subprocess-echo/src/main/java/org/apache/kudu/subprocess/echo/EchoProtocolHandler.java
M src/kudu/subprocess/subprocess.proto
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved
  Hao Hao: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabe9da298a1b71912ddc87f48834278d347d8514
Gerrit-Change-Number: 15184
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)