You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laserninja (via GitHub)" <gi...@apache.org> on 2026/09/15 03:19:31 UTC
[PR] Core: Parse optional null map values in SingleValueParser [iceberg]
laserninja opened a new pull request, #18118:
URL: https://github.com/apache/iceberg/pull/18118
Fixes #18117.
`SingleValueParser.toJson` can serialize an optional null map value, but `fromJson` fails on that output because `ImmutableMap.Builder` rejects nulls.
Build a `LinkedHashMap` and return an unmodifiable view to preserve iteration order and immutability while accepting optional null values. Explicitly reject null keys, duplicate keys (including an earlier null value), and null required values with argument errors.
Validation on JDK 17: the five new regressions failed before the fix. `TestSingleValueParser`, `TestSchemaParser`, `TestDataTaskParser`, `TestContentFileParser`, and `TestExpressionParser` passed afterward, along with core formatting and `revapi` checks.
---
**AI Disclosure**
- Model: GPT-6
- Platform/Tool: Codex
- Human Oversight: unreviewed
- Prompt Summary: Reproduce and fix optional null map value parsing, preserve validation and immutability, and create an issue and PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parse optional null map values in SingleValueParser [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #18118:
URL: https://github.com/apache/iceberg/pull/18118#issuecomment-5679355776
For further review, cc @nastra who has more context in core serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parse optional null map values in SingleValueParser [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18118:
URL: https://github.com/apache/iceberg/pull/18118#issuecomment-6227297553
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parse optional null map values in SingleValueParser [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #18118: Core: Parse optional null map values in SingleValueParser
URL: https://github.com/apache/iceberg/pull/18118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Parse optional null map values in SingleValueParser [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18118:
URL: https://github.com/apache/iceberg/pull/18118#issuecomment-6377481973
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org