[GitHub] [arrow-rs] HaoYang670 commented on pull request #1645: Remove `StringOffsetTrait` and `BinaryOffsetTrait`

[GitBox <gi...@apache.org>]

HaoYang670 commented on PR #1645:
URL: https://github.com/apache/arrow-rs/pull/1645#issuecomment-1117983851

   > Hmm, why don't we just make a `const` `is_large` in `OffsetSizeTrait` simply?
   > 
   > ```rust
   > pub trait OffsetSizeTrait {
   >   const IS_LARGE: bool;
   > }
   > impl OffsetSizeTrait for i32 {
   >     const IS_LARGE: bool = false;
   > }
   > 
   > impl OffsetSizeTrait for i64 {
   >     const IS_LARGE: bool = true
   > }
   > ```
   Strongly agree with you! 
   We could create a follow-up issue to track this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org