You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/22 12:07:30 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #5993: [INLONG-5967][Manager] OpenAPI of cluster management
vernedeng opened a new pull request, #5993:
URL: https://github.com/apache/inlong/pull/5993
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5967
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng closed pull request #5993: [INLONG-5967][Manager] Add save and delete interfaces of cluster management in OpenAPI
Posted by GitBox <gi...@apache.org>.
vernedeng closed pull request #5993: [INLONG-5967][Manager] Add save and delete interfaces of cluster management in OpenAPI
URL: https://github.com/apache/inlong/pull/5993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on pull request #5993: [INLONG-5967][Manager] Add save and delete interfaces of cluster management in OpenAPI
Posted by GitBox <gi...@apache.org>.
vernedeng commented on PR #5993:
URL: https://github.com/apache/inlong/pull/5993#issuecomment-1291411548
the cluster managerment will be done by the users, instead of integrating it in inlong manager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5993: [INLONG-5967][Manager] OpenAPI of cluster management
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5993:
URL: https://github.com/apache/inlong/pull/5993#discussion_r978183745
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java:
##########
@@ -90,6 +91,16 @@ public interface InlongClusterService {
*/
Integer save(ClusterRequest request, String operator);
+ /**
+ * Save raw cluster info.
+ *
+ * This method should be repeatable.
+ *
+ * @param request raw inlong cluster info
+ * @return cluster id after saving
+ */
+ Integer saveRaw(InlongClusterEntity request);
Review Comment:
Please re-use the above save method.
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/OpenClusterController.java:
##########
@@ -57,4 +59,17 @@ public Response<PageResult<ClusterInfo>> list(@RequestBody ClusterPageRequest re
return Response.success(clusterService.list(request));
}
+ @PostMapping(value = "/cluster/insert")
+ @ApiOperation(value = "insert raw cluster info")
+ public Response<Integer> insert(@RequestBody InlongClusterEntity request) {
Review Comment:
The controller layer should not use the entity from the dao layer directly.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java:
##########
@@ -90,6 +91,16 @@ public interface InlongClusterService {
*/
Integer save(ClusterRequest request, String operator);
+ /**
+ * Save raw cluster info.
+ *
+ * This method should be repeatable.
+ *
+ * @param request raw inlong cluster info
+ * @return cluster id after saving
+ */
+ Integer saveRaw(InlongClusterEntity request);
Review Comment:
Please re-use the above save method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on pull request #5993: [INLONG-5967][Manager] Add save and delete interfaces of cluster management in OpenAPI
Posted by GitBox <gi...@apache.org>.
vernedeng commented on PR #5993:
URL: https://github.com/apache/inlong/pull/5993#issuecomment-1272434153
The registration process of sort-standalone task will be interageted into manager sdk, instead of openapi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org