You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/01/22 20:25:34 UTC
[GitHub] [spark] itholic opened a new pull request, #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
itholic opened a new pull request, #39702:
URL: https://github.com/apache/spark/pull/39702
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_1020, "INVALID_USAGE_OF_STAR".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1615031217
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1419745482
@itholic Could you write a test for the case when `elem` contains `regular expression`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39702:
URL: https://github.com/apache/spark/pull/39702#discussion_r1083999733
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1050,15 +1052,17 @@ class AnalysisErrorSuite extends AnalysisTest {
val t2 = LocalRelation(b, c).as("t2")
// SELECT * FROM t1 WHERE a = (SELECT sum(c) FROM t2 WHERE t1.* = t2.b)
- assertAnalysisError(
+ assertAnalysisErrorClass(
Filter(EqualTo(a, ScalarSubquery(t2.select(sum(c)).where(star("t1") === b))), t1),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
)
// SELECT * FROM t1 JOIN t2 ON (EXISTS (SELECT 1 FROM t2 WHERE t1.* = b))
- assertAnalysisError(
+ assertAnalysisErrorClass(
t1.join(t2, condition = Some(Exists(t2.select(1).where(star("t1") === b)))),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
Review Comment:
Could you output a sql statement instead of internal node name, for example `WHERE` instead of `Filter`?
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -329,10 +329,12 @@ class AnalysisErrorSuite extends AnalysisTest {
"UNRESOLVED_COLUMN.WITH_SUGGESTION",
Map("objectName" -> "`havingCondition`", "proposal" -> "`max(b)`"))
- errorTest(
+ errorClassTest(
"unresolved star expansion in max",
testRelation2.groupBy($"a")(sum(UnresolvedStar(None))),
- "Invalid usage of '*' in expression 'sum'." :: Nil)
+ errorClass = "INVALID_USAGE_OF_STAR",
+ messageParameters = Map("elem" -> "'*'", "prettyName" -> "expression 'sum'")
Review Comment:
Please, wrap the function name by backticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
URL: https://github.com/apache/spark/pull/39702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1399797614
cc @MaxGekk @srielau @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1614954337
CI passed. cc @MaxGekk FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1489668136
@MaxGekk Can you take a look when you find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1427721497
Gentle reminder for @MaxGekk on previous updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39702:
URL: https://github.com/apache/spark/pull/39702#discussion_r1086259893
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1050,15 +1052,17 @@ class AnalysisErrorSuite extends AnalysisTest {
val t2 = LocalRelation(b, c).as("t2")
// SELECT * FROM t1 WHERE a = (SELECT sum(c) FROM t2 WHERE t1.* = t2.b)
- assertAnalysisError(
+ assertAnalysisErrorClass(
Filter(EqualTo(a, ScalarSubquery(t2.select(sum(c)).where(star("t1") === b))), t1),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
)
// SELECT * FROM t1 JOIN t2 ON (EXISTS (SELECT 1 FROM t2 WHERE t1.* = b))
- assertAnalysisError(
+ assertAnalysisErrorClass(
t1.join(t2, condition = Some(Exists(t2.select(1).where(star("t1") === b)))),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
Review Comment:
Thanks @MaxGekk for review.
I tried to output a SQL statement here, but unfortunately I couldn't proper way to expose the SQL statement rather than node name 😢
The code path is here:
https://github.com/apache/spark/blob/866343c7be47d71b88ae9a6b4dda26f8c4f5964b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L247-L250
The type of `operator` is `LogicalPlan`, and `s` is `Star` here.
Can we extract the SQL statement from these objects?
Do you happen to help outputting a SQL statement here??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39702:
URL: https://github.com/apache/spark/pull/39702#discussion_r1095308213
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1050,15 +1052,17 @@ class AnalysisErrorSuite extends AnalysisTest {
val t2 = LocalRelation(b, c).as("t2")
// SELECT * FROM t1 WHERE a = (SELECT sum(c) FROM t2 WHERE t1.* = t2.b)
- assertAnalysisError(
+ assertAnalysisErrorClass(
Filter(EqualTo(a, ScalarSubquery(t2.select(sum(c)).where(star("t1") === b))), t1),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
)
// SELECT * FROM t1 JOIN t2 ON (EXISTS (SELECT 1 FROM t2 WHERE t1.* = b))
- assertAnalysisError(
+ assertAnalysisErrorClass(
t1.join(t2, condition = Some(Exists(t2.select(1).where(star("t1") === b)))),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
Review Comment:
@MaxGekk could you happen to take a look at the previous comments when you find some time?
Also cc @cloud-fan for reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1420179550
Oh, seems like they already in `sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala`.
Let me update them to use `checkError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39702:
URL: https://github.com/apache/spark/pull/39702#issuecomment-1420198767
Updated tests, and also rename the error class as `INVALID_USAGE_OF_STAR_OR_REGEX`, instead if `INVALID_USAGE_OF_STAR` since it also manage the case for invalid usage of regular expression.
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39702: [SPARK-41487][SQL] Assign name to _LEGACY_ERROR_TEMP_1020
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39702:
URL: https://github.com/apache/spark/pull/39702#discussion_r1086279876
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1050,15 +1052,17 @@ class AnalysisErrorSuite extends AnalysisTest {
val t2 = LocalRelation(b, c).as("t2")
// SELECT * FROM t1 WHERE a = (SELECT sum(c) FROM t2 WHERE t1.* = t2.b)
- assertAnalysisError(
+ assertAnalysisErrorClass(
Filter(EqualTo(a, ScalarSubquery(t2.select(sum(c)).where(star("t1") === b))), t1),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
)
// SELECT * FROM t1 JOIN t2 ON (EXISTS (SELECT 1 FROM t2 WHERE t1.* = b))
- assertAnalysisError(
+ assertAnalysisErrorClass(
t1.join(t2, condition = Some(Exists(t2.select(1).where(star("t1") === b)))),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
Review Comment:
I tried to `operator.expressions.map(toPrettySQL).mkString(",")`, but it returns `"(unresolvedstar() = b)"`.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1050,15 +1052,17 @@ class AnalysisErrorSuite extends AnalysisTest {
val t2 = LocalRelation(b, c).as("t2")
// SELECT * FROM t1 WHERE a = (SELECT sum(c) FROM t2 WHERE t1.* = t2.b)
- assertAnalysisError(
+ assertAnalysisErrorClass(
Filter(EqualTo(a, ScalarSubquery(t2.select(sum(c)).where(star("t1") === b))), t1),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
)
// SELECT * FROM t1 JOIN t2 ON (EXISTS (SELECT 1 FROM t2 WHERE t1.* = b))
- assertAnalysisError(
+ assertAnalysisErrorClass(
t1.join(t2, condition = Some(Exists(t2.select(1).where(star("t1") === b)))),
- "Invalid usage of '*' in Filter" :: Nil
+ expectedErrorClass = "INVALID_USAGE_OF_STAR",
+ expectedMessageParameters = Map("elem" -> "'*'", "prettyName" -> "Filter")
Review Comment:
I tried to `operator.expressions.map(toPrettySQL).mkString(",")` to make SQL expression, but it returns `"(unresolvedstar() = b)"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org