You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by fe...@apache.org on 2004/02/27 07:49:10 UTC
svn commit: rev 6907 - incubator/spamassassin/trunk/lib/Mail/SpamAssassin
Author: felicity
Date: Thu Feb 26 22:49:09 2004
New Revision: 6907
Modified:
incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
Log:
bug 2836: scan_directories() would require that there be no whitespace in filenames, but spaces are valid in file names, so fix the RE to ignore what we don't want (starts with . or ,) and allow anything else.
Modified: incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
==============================================================================
--- incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm (original)
+++ incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm Thu Feb 26 22:49:09 2004
@@ -506,7 +506,7 @@
}
else {
# ignore ,234 (deleted or refiled messages) and MH metadata dotfiles
- @files = grep { /^[^,.]\S*$/ } readdir(DIR);
+ @files = grep { !/^[^,.]/ } readdir(DIR);
}
closedir(DIR);
Re: svn commit: rev 6907 - incubator/spamassassin/trunk/lib/Mail/SpamAssassin
Posted by Theo Van Dinter <fe...@kluge.net>.
On Fri, Feb 27, 2004 at 01:18:57AM -0600, Michael Parker wrote:
> > - @files = grep { /^[^,.]\S*$/ } readdir(DIR);
> > + @files = grep { !/^[^,.]/ } readdir(DIR);
>
> I haven't figured out why yet, but this broke the sa-learn tests in
> bayesdbm.t
Yeah, I was just noticing that ... Very strange.
> Ok, should it be this instead? @files = grep { /^[^,.]/ } readdir(DIR);
Well, hrm. Ah... It should actually be !/^[,.]/ ... <grrr> I'll
commit the fix in a minute.
--
Randomly Generated Tagline:
"It's not a huge rocket science thing, but it is a little bit funky ..."
- Instructor Otten
Re: svn commit: rev 6907 - incubator/spamassassin/trunk/lib/Mail/SpamAssassin
Posted by Michael Parker <pa...@pobox.com>.
On Fri, Feb 27, 2004 at 01:18:57AM -0600, Michael Parker wrote:
> On Fri, Feb 27, 2004 at 06:49:10AM -0000, felicity@apache.org wrote:
> > Author: felicity
> > Date: Thu Feb 26 22:49:09 2004
> > New Revision: 6907
> >
> > Modified:
> > incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
> > Log:
> > bug 2836: scan_directories() would require that there be no whitespace in filenames, but spaces are valid in file names, so fix the RE to ignore what we don't want (starts with . or ,) and allow anything else.
> >
> > Modified: incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
> > ==============================================================================
> > --- incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm (original)
> > +++ incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm Thu Feb 26 22:49:09 2004
> > @@ -506,7 +506,7 @@
> > }
> > else {
> > # ignore ,234 (deleted or refiled messages) and MH metadata dotfiles
> > - @files = grep { /^[^,.]\S*$/ } readdir(DIR);
> > + @files = grep { !/^[^,.]/ } readdir(DIR);
> > }
> > closedir(DIR);
> >
> >
>
>
> I haven't figured out why yet, but this broke the sa-learn tests in
> bayesdbm.t
>
Ok, should it be this instead? @files = grep { /^[^,.]/ } readdir(DIR);
Michael
Re: svn commit: rev 6907 - incubator/spamassassin/trunk/lib/Mail/SpamAssassin
Posted by Michael Parker <pa...@pobox.com>.
On Fri, Feb 27, 2004 at 06:49:10AM -0000, felicity@apache.org wrote:
> Author: felicity
> Date: Thu Feb 26 22:49:09 2004
> New Revision: 6907
>
> Modified:
> incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
> Log:
> bug 2836: scan_directories() would require that there be no whitespace in filenames, but spaces are valid in file names, so fix the RE to ignore what we don't want (starts with . or ,) and allow anything else.
>
> Modified: incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
> ==============================================================================
> --- incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm (original)
> +++ incubator/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm Thu Feb 26 22:49:09 2004
> @@ -506,7 +506,7 @@
> }
> else {
> # ignore ,234 (deleted or refiled messages) and MH metadata dotfiles
> - @files = grep { /^[^,.]\S*$/ } readdir(DIR);
> + @files = grep { !/^[^,.]/ } readdir(DIR);
> }
> closedir(DIR);
>
>
I haven't figured out why yet, but this broke the sa-learn tests in
bayesdbm.t
Michael