You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/02 03:55:26 UTC
[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17194:
Enhancements for custom subgraph op
samskalicky edited a comment on issue #17194: Enhancements for custom subgraph op
URL: https://github.com/apache/incubator-mxnet/pull/17194#issuecomment-570113206
@wkcn
> Is it available to copy a custom subgraph op test into `tests/python/unitest/test_extensions.py`?
The current subgraph op has an example tests here, but is SUPER hacky:
https://github.com/apache/incubator-mxnet/blob/e65fc4bee5b8602b38ba2e419a4ea2e5ce5b7e9a/example/extensions/lib_custom_op/test_subgraph.py#L47-L56
In this example we're literally doing a string replace to change the op in the symbol json string. This isnt something we want to test in the CI. Typically subgraph ops are inserted when the graph is partitioned.
It will be officially tested in test_extensions.py in the other PR that adds support for custom subgraph properties and actually uses custom subgraph ops in #17034 here are the code changes:
https://github.com/apache/incubator-mxnet/pull/17034/files#diff-460d06cb3af2af996c5ec259b086712fR87-R150
This PR (#17194) modifies the custom op that is used in that test with the changes in this PR:
https://github.com/apache/incubator-mxnet/pull/17194/files#diff-4347bc72a85f439003da183493ba2089R87
Would be great to get your feedback on #17034 too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services