You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/16 01:43:50 UTC

[GitHub] [flink] xiaoHoly removed a comment on pull request #14387: [FLINK-19691][Connector][jdbc] Expose `CONNECTION_CHECK_TIMEOUT_SECONDS` as a configurable option in Jdbc connector

xiaoHoly removed a comment on pull request #14387:
URL: https://github.com/apache/flink/pull/14387#issuecomment-745708634


   > Thanks for your contribution @xiaoHoly.
   > We should expose a ConfigOption like JdbcDynamicTableFactory#PASSWORD.
   > The configOption key can be `connection.check.timeout` and the type is duration.
   > And we also should add a test to verify this configOption in JdbcDynamicTableFactoryTest.
   thanks for your suggestion,i will do it
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org