You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/25 11:58:04 UTC
[GitHub] [pulsar-client-cpp] yaalsn opened a new pull request, #72: Add windows release artifacts
yaalsn opened a new pull request, #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72
### Motivation
Add windows release artifacts and create a release with artifacts after pushing tag.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] yaalsn commented on pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1294490244
@merlimat The uploaded artifacts are release artifacts which need by users, and they don't need to build by themself. The token is GITHUB_TOKEN which is a builtin token in GitHub action so that we can use it directly.
About GITHUB_TOKEN:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] shibd commented on pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1294725558
> @merlimat The uploaded artifacts are release artifacts needed by users, and they don't need to build themself. The token is GITHUB_TOKEN which is a builtin token in GitHub action so that we can use it directly.
>
> About GITHUB_TOKEN:
>
> https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
I think we need to keep uploading the binaries to GH action artifacts. This is required for the current release process. You can refer to the following:
- https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#sign-and-stage-the-artifacts
- https://github.com/apache/pulsar-client-cpp/blob/main/build-support/stage-release.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] merlimat commented on pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1293494580
@yaalsn @BewareMyPower This has changed from uploading the binaries to GH actions artifacts into a release. It is breaking the release workflow.
First, we still must upload as artifacts, but also we may not have the credentials to upload to GH releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] merlimat commented on pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1296282490
@yaalsn we could keep the upload to GH release as an optional step, enabled only if some flag is set. For Apache releases, we need to anyway follow the process of staging the binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] yaalsn commented on pull request #72: Add windows release artifacts
Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1296087359
Thanks @shibd, I didn't notice the release guide before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org