You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/25 11:37:19 UTC
[GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3989
[FLINK-6719] Activate strict checkstyle for flink-clients
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6718_cs_cl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3989
----
commit aae7b02ad1b84042e522c65db18a9e3f2077b210
Author: zentol <ch...@apache.org>
Date: 2017-05-25T11:02:36Z
[FLINK-6719] Activate strict checkstyle for flink-clients
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3989: [FLINK-6719] Activate strict checkstyle for flink-clients
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3989
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3989#discussion_r118492307
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -369,68 +372,87 @@ public static void main(String[] args) throws Exception {
.fieldDelimiter("\t").types(Long.class, Long.class);
DataSet<Tuple2<Long, Long>> result = input.map(
- new MapFunction<Tuple2<Long,Long>, Tuple2<Long,Long>>() {
+ new MapFunction<Tuple2<Long, Long>, Tuple2<Long, Long>>() {
public Tuple2<Long, Long> map(Tuple2<Long, Long> value){
- return new Tuple2<Long, Long>(value.f0, value.f1+1);
+ return new Tuple2<Long, Long>(value.f0, value.f1 + 1);
}
});
result.writeAsCsv(args[1], "\n", "\t");
env.execute();
}
+
@Override
public String getDescription() {
return "TestOptimizerPlan <input-file-path> <output-file-path>";
}
}
+ /**
+ * That job that calls {@link ExecutionEnvironment#execute()} twice.
--- End diff --
"That" -> "Test"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3989#discussion_r118558312
--- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -369,68 +372,87 @@ public static void main(String[] args) throws Exception {
.fieldDelimiter("\t").types(Long.class, Long.class);
DataSet<Tuple2<Long, Long>> result = input.map(
- new MapFunction<Tuple2<Long,Long>, Tuple2<Long,Long>>() {
+ new MapFunction<Tuple2<Long, Long>, Tuple2<Long, Long>>() {
public Tuple2<Long, Long> map(Tuple2<Long, Long> value){
- return new Tuple2<Long, Long>(value.f0, value.f1+1);
+ return new Tuple2<Long, Long>(value.f0, value.f1 + 1);
}
});
result.writeAsCsv(args[1], "\n", "\t");
env.execute();
}
+
@Override
public String getDescription() {
return "TestOptimizerPlan <input-file-path> <output-file-path>";
}
}
+ /**
+ * That job that calls {@link ExecutionEnvironment#execute()} twice.
--- End diff --
will fix it while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---