You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 22:15:16 UTC
[GitHub] [spark] kevinyu98 opened a new pull request #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
kevinyu98 opened a new pull request #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Based on [JIRA 30962](https://issues.apache.org/jira/browse/SPARK-30962), we want to add all the support `Alter Table` syntax for V1 table.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
Yes
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Before:
The documentation looks like
[Alter Table](https://github.com/apache/spark/pull/25590)
After:
<img width="850" alt="Screen Shot 2020-03-03 at 2 02 23 PM" src="https://user-images.githubusercontent.com/7550280/75824837-168c7e00-5d59-11ea-9751-d1dab0f5a892.png">
<img width="977" alt="Screen Shot 2020-03-03 at 2 02 41 PM" src="https://user-images.githubusercontent.com/7550280/75824859-21dfa980-5d59-11ea-8b49-3adf6eb55fc6.png">
<img width="1028" alt="Screen Shot 2020-03-03 at 2 02 59 PM" src="https://user-images.githubusercontent.com/7550280/75824884-2e640200-5d59-11ea-81ef-d77d0a8efee2.png">
<img width="864" alt="Screen Shot 2020-03-03 at 2 03 14 PM" src="https://user-images.githubusercontent.com/7550280/75824910-39b72d80-5d59-11ea-84d0-bffa2499f086.png">
<img width="823" alt="Screen Shot 2020-03-03 at 2 03 28 PM" src="https://user-images.githubusercontent.com/7550280/75824937-45a2ef80-5d59-11ea-932c-314924856834.png">
<img width="811" alt="Screen Shot 2020-03-03 at 2 03 42 PM" src="https://user-images.githubusercontent.com/7550280/75824965-4cc9fd80-5d59-11ea-815b-8c1ebad310b1.png">
<img width="827" alt="Screen Shot 2020-03-03 at 2 03 53 PM" src="https://user-images.githubusercontent.com/7550280/75824978-518eb180-5d59-11ea-8a55-2fa26376b9c1.png">
<img width="783" alt="Screen Shot 2020-03-03 at 2 04 03 PM" src="https://user-images.githubusercontent.com/7550280/75825001-5bb0b000-5d59-11ea-8dd9-dcfbfa1b4330.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596870212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119595/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280124
**[Test build #119271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119271/testReport)** for PR 27779 at commit [`6f74d6c`](https://github.com/apache/spark/commit/6f74d6cb632f873bbb208c6cdc80d4f253fcf397).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390659062
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,109 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
Review comment:
You forgot to address the @huajianmao comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389432346
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
Review comment:
Thanks, changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24010/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596734433
**[Test build #119583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119583/testReport)** for PR 27779 at commit [`1d7aa01`](https://github.com/apache/spark/commit/1d7aa01206a90a282e9f1f06a3c561e27ef2ec1f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594283229
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119271/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390672795
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,109 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389455232
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -248,6 +349,86 @@ DESC StudentInfo;
| age | int | NULL |
+--------------------------+------------+----------+--+
+-- Add new partition to a table
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389212628
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [ IF NOT EXISTS ] partition_spec
Review comment:
It's possible to add multiple partitions in one go, so we should show that in the syntax and examples.
For reference, here's how I wrote up the syntax for `ADD PARTITION`: https://github.com/apache/spark/pull/27840/files#diff-1029db085c19beee649492b52c628596R93-R95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390023547
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -274,5 +482,6 @@ ALTER TABLE dbx.tab1 UNSET TBLPROPERTIES ('winner')
### Related Statements
- [CREATE TABLE](sql-ref-syntax-ddl-create-table.html)
- [DROP TABLE](sql-ref-syntax-ddl-drop-table.html)
+- [ALTER TABLE ... ADD PARTITION](sql-ref-syntax-ddl-alter-table.html)
Review comment:
is this change intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389435218
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
Review comment:
No, it didn't recovery the partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280527
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r388008651
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
Review comment:
Does ```RECOVER PARTITIONS``` work for V1 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596870142
**[Test build #119595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119595/testReport)** for PR 27779 at commit [`6c19a94`](https://github.com/apache/spark/commit/6c19a94df684036dcd894d7aa83c3bbfec14d77b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594198803
@huaxingao @dilipbiswal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597361372
Pending the fix: https://github.com/apache/spark/pull/27779#discussion_r390490103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389349766
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -248,6 +349,86 @@ DESC StudentInfo;
| age | int | NULL |
+--------------------------+------------+----------+--+
+-- Add new partition to a table
Review comment:
nit: `new partition` -> `a new partition`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594283155
**[Test build #119271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119271/testReport)** for PR 27779 at commit [`6f74d6c`](https://github.com/apache/spark/commit/6f74d6cb632f873bbb208c6cdc80d4f253fcf397).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597373540
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390046066
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,110 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the column to be altered or be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [IF NOT EXISTS]
+ PARTITION <partition_spec>
+ [ PARTITION <partition_spec> ...]
Review comment:
`,` is not part of the syntax in Spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596734635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119583/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390023455
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,110 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the column to be altered or be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [IF NOT EXISTS]
+ PARTITION <partition_spec>
+ [ PARTITION <partition_spec> ...]
Review comment:
change to
```
ALTER TABLE table_identifier ADD [ IF NOT EXISTS ]
( partition_spec [ , partition_spec ... ] )
```
so the format is consistent with others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596868145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24326/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594199551
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596870204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597374415
Thanks! Merged to master/branch-3.0. cc: @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280124
**[Test build #119271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119271/testReport)** for PR 27779 at commit [`6f74d6c`](https://github.com/apache/spark/commit/6f74d6cb632f873bbb208c6cdc80d4f253fcf397).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390058450
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,110 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the column to be altered or be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [IF NOT EXISTS]
+ PARTITION <partition_spec>
+ [ PARTITION <partition_spec> ...]
Review comment:
I will make changes. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596726409
**[Test build #119583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119583/testReport)** for PR 27779 at commit [`1d7aa01`](https://github.com/apache/spark/commit/1d7aa01206a90a282e9f1f06a3c561e27ef2ec1f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594199551
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596734623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389455570
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -248,6 +349,86 @@ DESC StudentInfo;
| age | int | NULL |
+--------------------------+------------+----------+--+
+-- Add new partition to a table
+
+SHOW PARTITIONS StudentInfo;
++------------+--+
+| partition |
++------------+--+
+| age=11 |
+| age=12 |
+| age=15 |
++------------+--+
+
+ALTER TABLE StudentInfo ADD IF NOT EXISTS PARTITION (age=18);
+
+-- After adding new partition to the table
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594283227
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596722927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24310/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596722919
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390488947
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,110 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the column to be altered or be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [IF NOT EXISTS]
+ PARTITION <partition_spec>
+ [ PARTITION <partition_spec> ...]
Review comment:
@nchammas You are right. No ```,```. Thanks for catching this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24010/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r388008600
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
Review comment:
I saw the following in ```SqlBase.g4```. Can ```alterColumnAction``` change type, colPosition, setOrDrop as well?
```
alterColumnAction
: TYPE dataType
| commentSpec
| colPosition
| setOrDrop=(SET | DROP) NOT NULL
;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596868141
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594200113
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596868145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24326/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389349787
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -248,6 +349,86 @@ DESC StudentInfo;
| age | int | NULL |
+--------------------------+------------+----------+--+
+-- Add new partition to a table
+
+SHOW PARTITIONS StudentInfo;
++------------+--+
+| partition |
++------------+--+
+| age=11 |
+| age=12 |
+| age=15 |
++------------+--+
+
+ALTER TABLE StudentInfo ADD IF NOT EXISTS PARTITION (age=18);
+
+-- After adding new partition to the table
Review comment:
nit: `new partition` -> `a new partition`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390058368
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -274,5 +482,6 @@ ALTER TABLE dbx.tab1 UNSET TBLPROPERTIES ('winner')
### Related Statements
- [CREATE TABLE](sql-ref-syntax-ddl-create-table.html)
- [DROP TABLE](sql-ref-syntax-ddl-drop-table.html)
+- [ALTER TABLE ... ADD PARTITION](sql-ref-syntax-ddl-alter-table.html)
Review comment:
oh, I thought that one is part of umbrella jira, so tried to reference. Thanks for catching this, I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597373547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24368/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389454554
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
+ <b>Syntax:</b>
+ <code>
+ COMMENT STRING
+ </code>
+ </dd>
+</dl>
+
+
+### ADD AND DROP PARTITION
+
+#### ADD PARTITION
+`ALTER TABLE ADD` statement adds partition to the partitioned table.
+
+##### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier ADD [ IF NOT EXISTS ] partition_spec
Review comment:
Yes, it is possible, I will add. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597373547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24368/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389434757
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
+</dl>
+
+<dl>
+ <dt><code><em>alterColumnAction</em></code></dt>
+ <dd>
+ Change the comment string.<br><br>
Review comment:
I tested those: datatype, colPosition, set/drop not null, I got error which states v1 table can't do or only supported with v2 tables. So I didn't put those in the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596734635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119583/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596870212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119595/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596722919
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596868141
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594278933
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594283227
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596867789
**[Test build #119595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119595/testReport)** for PR 27779 at commit [`6c19a94`](https://github.com/apache/spark/commit/6c19a94df684036dcd894d7aa83c3bbfec14d77b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389349609
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
Review comment:
`COLUMN` is optional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-597373540
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596722927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24310/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r388008280
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
+{% endhighlight %}
+
+#### Parameters
+<dl>
+ <dt><code><em>table_identifier</em></code></dt>
+ <dd>
+ Specifies a table name, which may be optionally qualified with a database name.<br><br>
+ <b>Syntax:</b>
+ <code>
+ [ database_name. ] table_name
+ </code>
+ </dd>
+</dl>
+
+<dl>
+ <dt><code><em>COLUMN col_spec</em></code></dt>
+ <dd>Specifies the columns to be altered to be changed.</dd>
Review comment:
Nit: ```columns``` -> ```column```?
I guess you missed ```or``` after ```to be altered```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594280527
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594283229
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119271/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-594200113
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390597339
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,109 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596726409
**[Test build #119583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119583/testReport)** for PR 27779 at commit [`1d7aa01`](https://github.com/apache/spark/commit/1d7aa01206a90a282e9f1f06a3c561e27ef2ec1f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596867789
**[Test build #119595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119595/testReport)** for PR 27779 at commit [`6c19a94`](https://github.com/apache/spark/commit/6c19a94df684036dcd894d7aa83c3bbfec14d77b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r390490103
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,109 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } [COLUMN] col_spec alterColumnAction
Review comment:
super nit: ```[COLUMN]``` ->``` [ COLUMN ]```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596734623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#issuecomment-596870204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #27779:
[SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
Posted by GitBox <gi...@apache.org>.
kevinyu98 commented on a change in pull request #27779: [SPARK-30962][SQL][DOC]Documentation for Alter table command phase 2
URL: https://github.com/apache/spark/pull/27779#discussion_r389455127
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -83,6 +82,108 @@ ALTER TABLE table_identifier ADD COLUMNS ( col_spec [ , col_spec ... ] )
</dl>
+### ALTER OR CHANGE COLUMN
+`ALTER TABLE ALTER COLUMN` or `ALTER TABLE CHANGE COLUMN` statement changes column's comment.
+
+#### Syntax
+{% highlight sql %}
+ALTER TABLE table_identifier { ALTER | CHANGE } COLUMN col_spec alterColumnAction
Review comment:
changed, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org