You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/13 07:23:22 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich opened a new issue, #18: Implement `deleteObject(persistenceId: String, revision: Long)` properly
mdedetrich opened a new issue, #18:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/18
As discussed in https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062, the current implementation of `deleteObject(persistenceId: String, revision: Long)` just defers to `deleteObject(persistenceId: String)` (which means it ignores the revision).
The implementation should instead be improved so it only deletes correct revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Implement `deleteObject(persistenceId: String, revision: Long)` properly [incubator-pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #18:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/18#issuecomment-1791939494
> @mdedetrich do you want this in 1.0.0?
Should go in `1.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Implement `deleteObject(persistenceId: String, revision: Long)` properly [incubator-pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #18:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/18#issuecomment-1791715100
@mdedetrich do you want this in 1.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org