You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by leonardofoderaro <gi...@git.apache.org> on 2015/09/12 00:02:50 UTC
[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn
GitHub user leonardofoderaro opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/299
a Js Intepreter, based on Nashorn
Hi all, I tried to implement my first Zeppelin Interpreter for Javascript. I filled a Jira ticket. Please let me know if I did something wrong (it's my first PR!) - thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/leonardofoderaro/incubator-zeppelin js_interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit 2651da39ec1ffc233919e001ee7f8cf413690275
Author: Leonardo Foderaro <le...@gmail.com>
Date: 2015-09-10T20:07:42Z
first import
commit 1b71c693a1e25b998d12404c5caefe073aab9219
Author: Leonardo Foderaro <le...@gmail.com>
Date: 2015-09-11T21:11:48Z
fix typo
commit be087d42cd08c8ac46336ecff94f9610a2cb4e57
Author: Leonardo Foderaro <le...@gmail.com>
Date: 2015-09-11T21:14:45Z
corrected output directory
commit dc6801a096ff1c5f3419a7df99401c0ac8b775fb
Author: Leonardo Foderaro <le...@gmail.com>
Date: 2015-09-11T21:29:35Z
fixed Checkstyle violations
commit 1c7778bf2043c68c5e97f54f593fbc8833b77460
Author: Leonardo Foderaro <le...@gmail.com>
Date: 2015-09-11T21:46:20Z
fixed typo in log
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139782977
@leonardofoderaro thank you for prompt response and do not worry, please take your time!
Also it's good practice to put issue number in the name of the PR, like 'ZEPPELIN-300: add Js Intepreter, based on Nashorn', to simplify things for the reviewers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139701580
Great contribution, thank you!
Could you explain a bit what's it for and how user will benefit from it?
Also, all new interpreter PRs should include some docs, so could you please add it to `/docs/`, more details on how to do that you can find here http://zeppelin.incubator.apache.org/docs/development/howtocontributewebsite.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn
Posted by leonardofoderaro <gi...@git.apache.org>.
Github user leonardofoderaro commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139740367
Thank you all for the feedback. Today I'm a bit busy, I'll work on both the code and the docs in these days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: a Js Intepreter, based on Nashorn
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/299#issuecomment-139692299
Could you please reference the JIRA ticket here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---