You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:10:41 UTC
[GitHub] [rocketmq-mqtt] tianliuliu opened a new pull request #28: [ISSUE #23]add unit test to increase codeCov
tianliuliu opened a new pull request #28:
URL: https://github.com/apache/rocketmq-mqtt/pull/28
fix #23 mqtt-ds/src/test/java/org/apache/rocketmq/mqtt/ds/test/LmqOffsetStoreManagerTest.java
add unit test for LmqOffsetStoreManagerTest.java to increase the codeCov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing commented on pull request #28: [ISSUE #23]add unit test to increase codeCov
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on pull request #28:
URL: https://github.com/apache/rocketmq-mqtt/pull/28#issuecomment-1066498042
try run “mvn -B clean apache-rat:check” local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #28: [ISSUE #23]add unit test to increase codeCov
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #28:
URL: https://github.com/apache/rocketmq-mqtt/pull/28#issuecomment-1066564783
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#28](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00a430e) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/0f2a83069584af74a6fa56e99c77cc497850a280?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f2a830) will **increase** coverage by `1.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 19.84% 21.09% +1.24%
==========================================
Files 87 87
Lines 3723 3721 -2
Branches 610 610
==========================================
+ Hits 739 785 +46
+ Misses 2776 2722 -54
- Partials 208 214 +6
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t/cs/protocol/mqtt/handler/MqttConnectHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dENvbm5lY3RIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/cs/protocol/mqtt/handler/MqttPublishHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1Ymxpc2hIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cs/protocol/mqtt/handler/MqttSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFN1YnNjcmliZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../rocketmq/mqtt/ds/store/LmqOffsetStoreManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9zdG9yZS9MbXFPZmZzZXRTdG9yZU1hbmFnZXIuamF2YQ==) | `63.01% <0.00%> (+63.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0f2a830...00a430e](https://codecov.io/gh/apache/rocketmq-mqtt/pull/28?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing merged pull request #28: [ISSUE #23]add unit test to increase codeCov
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #28:
URL: https://github.com/apache/rocketmq-mqtt/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing commented on a change in pull request #28: [ISSUE #23]add unit test to increase codeCov
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #28:
URL: https://github.com/apache/rocketmq-mqtt/pull/28#discussion_r825683973
##########
File path: mqtt-ds/src/test/java/org/apache/rocketmq/mqtt/ds/test/LmqOffsetStoreManagerTest.java
##########
@@ -0,0 +1,119 @@
+package org.apache.rocketmq.mqtt.ds.test;
Review comment:
add license header here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org