You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/07/28 11:47:28 UTC

[PR] Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

maobaolong opened a new pull request, #1971:
URL: https://github.com/apache/incubator-uniffle/pull/1971

   
   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. Contributor guidelines:
      https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   3. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   (Please outline the changes and how this PR fixes the issue.)
   
   ### Why are the changes needed?
   
   (Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, describe the bug.)
   
   Fix: # (issue)
   
   ### Does this PR introduce _any_ user-facing change?
   
   (Please list the user-facing changes introduced by your change, including
     1. Change in user-facing APIs.
     2. Addition or removal of property keys.)
   
   No.
   
   ### How was this patch tested?
   
   (Please test your changes, and provide instructions on how to test it:
     1. If you add a feature or fix a bug, add a test to cover your changes. 
     2. If you fix a flaky test, repeat it for many times to prove it works.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1971:
URL: https://github.com/apache/incubator-uniffle/pull/1971#issuecomment-2254569753

   Could you add a ut for this case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1971:
URL: https://github.com/apache/incubator-uniffle/pull/1971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1971:
URL: https://github.com/apache/incubator-uniffle/pull/1971#issuecomment-2316693357

   @jerqi UT has been added, PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1971:
URL: https://github.com/apache/incubator-uniffle/pull/1971#issuecomment-2254512775

   ## Test Results
    2 747 files  ±0   2 747 suites  ±0   9h 47m 43s :stopwatch: - 3m 15s
      979 tests ±0     978 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0 
   12 294 runs  ±0  12 279 :white_check_mark: ±0  15 :zzz: ±0  0 :x: ±0 
   
   Results for commit 28153fc5. ± Comparison against base commit 457c8653.
   
   [test-results]:data:application/gzip;base64,H4sIAOtBpmYC/03NTQ6DIBCG4asY1l0IOo70Ms10kITUnwZhZXr3jlaty+9h8rIoH/puVvfCYI23Qs05pOt2OVIK0yhSgWkqIXlP64VFe6zHnJk3av/0Cm8hfYKn0AuUJ3QxTnGXmMe1qY2x9T6PqNj208/2KhxwqW77GuVpGEKSoUyrofIMhLZsO2SqEZ6IXjvbuJIJwJFmsurzBQgR1qsSAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue [incubator-uniffle]

Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #1971: [#1972] fix(server): Fix clear leak shuffle data accidentally remove data of new coming appId issue
URL: https://github.com/apache/incubator-uniffle/pull/1971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org