You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/21 04:10:20 UTC

[GitHub] [incubator-hudi] garyli1019 opened a new pull request #1651: [MINOR] add impala release and spark partition discovery

garyli1019 opened a new pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651


   Minor doc edit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651#discussion_r428441106



##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -297,6 +298,7 @@ tripsSnapshotDF = spark. \
   read. \
   format("hudi"). \
   load(basePath + "/*/*/*/*")
+# load(basePath) use "/partitionKey=partitionValue" folder structure for Spark auto partition discovery

Review comment:
       this is python 🙈 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] lamber-ken commented on pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651#issuecomment-632313692


   👍 @garyli1019 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] leesf commented on a change in pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651#discussion_r428440522



##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -297,6 +298,7 @@ tripsSnapshotDF = spark. \
   read. \
   format("hudi"). \
   load(basePath + "/*/*/*/*")
+# load(basePath) use "/partitionKey=partitionValue" folder structure for Spark auto partition discovery

Review comment:
       \# -> //




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] lamber-ken commented on pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651#issuecomment-632314208


   @garyli1019 it would be nice to add more context about the pr next time : )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] leesf merged pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] leesf commented on a change in pull request #1651: [MINOR] add impala release and spark partition discovery

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1651:
URL: https://github.com/apache/incubator-hudi/pull/1651#discussion_r428440522



##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -297,6 +298,7 @@ tripsSnapshotDF = spark. \
   read. \
   format("hudi"). \
   load(basePath + "/*/*/*/*")
+# load(basePath) use "/partitionKey=partitionValue" folder structure for Spark auto partition discovery

Review comment:
       # -> //




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org