[GitHub] [hadoop] ben-roling commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure

[GitBox <gi...@apache.org>]

ben-roling commented on a change in pull request #666: HADOOP-16221 add option to fail operation on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#discussion_r270537789
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
 ##########
 @@ -3034,10 +3042,13 @@ private void setOptionalObjectMetadata(ObjectMetadata metadata) {
    * </ol>
    * @param key key written to
    * @param length  total length of file written
+   * @throws IOException if metadata about the write could
+   * not be saved to the metadata store
    */
   @InterfaceAudience.Private
-  @Retries.RetryExceptionsSwallowed
-  void finishedWrite(String key, long length) {
+  @Retries.OnceRaw
 
 Review comment:
   Yeah, I think I had the wrong impression of the expectations for the annotations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org