You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/12 20:10:46 UTC

[GitHub] [superset] nytai commented on a diff in pull request #21053: feat(api): add role, permission, user APIs

nytai commented on code in PR #21053:
URL: https://github.com/apache/superset/pull/21053#discussion_r944806636


##########
superset/initialization/__init__.py:
##########
@@ -28,6 +28,8 @@
 from flask_compress import Compress
 from werkzeug.middleware.proxy_fix import ProxyFix
 
+from flask_appbuilder.security.sqla.apis import PermissionApi, PermissionViewMenuApi, \
+    RoleApi, UserApi, ViewMenuApi

Review Comment:
   nit:
   ```suggestion
   from flask_appbuilder.security.sqla.apis import (
       PermissionApi, 
       PermissionViewMenuApi,
       RoleApi, 
       UserApi, 
       ViewMenuApi,
   )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org