[GitHub] storm issue #1807: fix NullPointException with acked.get(rtp)

[srdo <gi...@git.apache.org>]

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/1807
  
    Good catch. I think I'd prefer disabling the retry logic entirely when auto commit is enabled though. It doesn't really make sense to me that you would want to have Storm guarantee at least once processing for tuples from the Kafka spout, but also don't care about losing tuples if the Kafka spout crashes. It would be good IMO if we added the same type of check to fail() as ack() has, so we skip scheduling tuples for retry if auto commit is enabled.
    
    @hmcl do you have any thoughts on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---