You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/18 09:08:04 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request, #2878: apps/iptest: Make app more user friendly
kasjer opened a new pull request, #2878:
URL: https://github.com/apache/mynewt-core/pull/2878
net_test_socket could be created twice leading to memory leak now whenever 'socket' command is executed it closes previous socket first.
bind/listen/connect check if socket is created first and print message if it is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2878: apps/iptest: Make app more user friendly
Posted by GitBox <gi...@apache.org>.
kasjer merged PR #2878:
URL: https://github.com/apache/mynewt-core/pull/2878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2878: apps/iptest: Make app more user friendly
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2878:
URL: https://github.com/apache/mynewt-core/pull/2878#issuecomment-1250235007
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2878: apps/iptest: Make app more user friendly
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2878:
URL: https://github.com/apache/mynewt-core/pull/2878#issuecomment-1250226563
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### apps/iptest/src/main.c
<details>
```diff
@@ -125,12 +128,12 @@
net_cli_close_socket();
rc = mn_socket(&net_test_socket, MN_PF_INET, MN_SOCK_DGRAM, 0);
console_printf("mn_socket(UDP) = %d %x\n", rc,
- (int)net_test_socket);
+ (int)net_test_socket);
} else if (!strcmp(argv[1], "tcp")) {
net_cli_close_socket();
rc = mn_socket(&net_test_socket, MN_PF_INET, MN_SOCK_STREAM, 0);
console_printf("mn_socket(TCP) = %d %x\n", rc,
- (int)net_test_socket);
+ (int)net_test_socket);
} else if (!strcmp(argv[1], "connect") || !strcmp(argv[1], "bind")) {
if (argc < 4) {
return 0;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org