You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 02:09:40 UTC
[jira] [Created] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
flume-ng script has no way to add, not replace, classpath
---------------------------------------------------------
Key: FLUME-1078
URL: https://issues.apache.org/jira/browse/FLUME-1078
Project: Flume
Issue Type: Improvement
Components: Configuration
Affects Versions: v1.1.0
Reporter: Brock Noland
The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243807#comment-13243807 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-04-01 18:20:08, Arvind Prabhakar wrote:
bq. > +1
Thanks for the patch Brock. Please attach it to the Jira.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6610
-----------------------------------------------------------
On 2012-03-30 21:37:10, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 21:37:10)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1078:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
1327199
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-1078-1.patch
>
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242706#comment-13242706 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6588
-----------------------------------------------------------
Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""
One nit: whitespace at the end of line 107
- Mike
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243805#comment-13243805 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6610
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-03-30 21:37:10, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 21:37:10)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255736#comment-13255736 ]
Brock Noland commented on FLUME-1078:
-------------------------------------
Sorry I missed the +1 from Arvind. I will commit this now.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-1078-1.patch
>
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242788#comment-13242788 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6596
-----------------------------------------------------------
Looks good. Thanks Brock!
- Mike
On 2012-03-30 21:37:10, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 21:37:10)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242559#comment-13242559 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
This addresses bug FLUME-1078.
https://issues.apache.org/jira/browse/FLUME-1078
Diffs
-----
bin/flume-ng a31f171
Diff: https://reviews.apache.org/r/4574/diff
Testing
-------
Tested from the command line.
Thanks,
Brock
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242713#comment-13242713 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6589
-----------------------------------------------------------
Ship it!
+1. Agree with Mike's comment, though I don't see it as blocker.
- Hari
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242774#comment-13242774 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/
-----------------------------------------------------------
(Updated 2012-03-30 21:37:10.578885)
Review request for Flume.
Changes
-------
Updated patch attached.
Summary
-------
Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
This addresses bug FLUME-1078.
https://issues.apache.org/jira/browse/FLUME-1078
Diffs (updated)
-----
bin/flume-ng a31f171
Diff: https://reviews.apache.org/r/4574/diff
Testing
-------
Tested from the command line.
Thanks,
Brock
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242737#comment-13242737 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-03-30 20:28:46, Mike Percy wrote:
bq. > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""
bq. >
bq. > One nit: whitespace at the end of line 107
bq.
bq. Brock Noland wrote:
bq. Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:
bq.
bq. env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command
bq.
bq. Is there a reason we don't want to be compatible?
The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6588
-----------------------------------------------------------
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242717#comment-13242717 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-03-30 20:33:04, Hari Shreedharan wrote:
bq. > +1. Agree with Mike's comment, though I don't see it as blocker.
Comment about the shell specifying $FLUME_CLASSPATH, not the whitespace one :)
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6589
-----------------------------------------------------------
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1078:
------------------------------
Fix Version/s: v1.2.0
Assignee: Brock Noland
Status: Patch Available (was: Open)
Can we get this checked in?
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-1078-1.patch
>
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242716#comment-13242716 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-03-30 20:28:46, Mike Percy wrote:
bq. > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""
bq. >
bq. > One nit: whitespace at the end of line 107
Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:
env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command
Is there a reason we don't want to be compatible?
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6588
-----------------------------------------------------------
On 2012-03-30 17:16:57, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 17:16:57)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1078:
--------------------------------
Attachment: FLUME-1078-1.patch
patch from RB
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Attachments: FLUME-1078-1.patch
>
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255791#comment-13255791 ]
Hudson commented on FLUME-1078:
-------------------------------
Integrated in flume-trunk #173 (See [https://builds.apache.org/job/flume-trunk/173/])
FLUME-1078: flume-ng script has no way to add, not replace, classpath
(Brock Noland) (Revision 1327199)
Result = SUCCESS
brock : http://svn.apache.org/viewvc/?view=rev&rev=1327199
Files :
* /incubator/flume/trunk/bin/flume-ng
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-1078-1.patch
>
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1078) flume-ng script has no way to add,
not replace, classpath
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242780#comment-13242780 ]
jiraposter@reviews.apache.org commented on FLUME-1078:
------------------------------------------------------
bq. On 2012-03-30 20:28:46, Mike Percy wrote:
bq. > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""
bq. >
bq. > One nit: whitespace at the end of line 107
bq.
bq. Brock Noland wrote:
bq. Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:
bq.
bq. env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command
bq.
bq. Is there a reason we don't want to be compatible?
bq.
bq. Mike Percy wrote:
bq. The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service.
I am fine with this approach, I updated the patch. FWIW, the hadoop command is used to start all the hadoop daemons.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4574/#review6588
-----------------------------------------------------------
On 2012-03-30 21:37:10, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 21:37:10)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.
bq.
bq.
bq. This addresses bug FLUME-1078.
bq. https://issues.apache.org/jira/browse/FLUME-1078
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng a31f171
bq.
bq. Diff: https://reviews.apache.org/r/4574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested from the command line.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> flume-ng script has no way to add, not replace, classpath
> ---------------------------------------------------------
>
> Key: FLUME-1078
> URL: https://issues.apache.org/jira/browse/FLUME-1078
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Brock Noland
>
> The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira