You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2020/03/29 06:27:20 UTC

[GitHub] [shiro] bmhm commented on issue #208: modifying the thrown exceptions of SimplePrincipalCollection

bmhm commented on issue #208: modifying the thrown exceptions of SimplePrincipalCollection
URL: https://github.com/apache/shiro/pull/208#issuecomment-605589856
 
 
   Two additional comments
   
   1. Please update the title of this PR, the issue in square brackets.
   2. I know this is an API change. But for NPE, I feel this is very justified and no one should have cought this exception in the first place. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services