You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/19 02:55:32 UTC
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2170: [Feature][Flink SQL CDC] Add "MySQL CDC Source Connector"
ashulin commented on code in PR #2170:
URL: https://github.com/apache/incubator-seatunnel/pull/2170#discussion_r924012705
##########
seatunnel-core/seatunnel-core-flink-sql/pom.xml:
##########
@@ -60,6 +60,16 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.ververica</groupId>
+ <artifactId>flink-sql-connector-mysql-cdc</artifactId>
+ <version>${flink.cdc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-runtime-web_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
Review Comment:
```suggestion
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-runtime-web_${scala.binary.version}</artifactId>
</dependency>
```
nit: The dependencies in `<dependencyManagement>` are referenced here, `<version>` can be omitted
##########
seatunnel-core/seatunnel-core-flink-sql/pom.xml:
##########
@@ -60,6 +60,16 @@
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.ververica</groupId>
+ <artifactId>flink-sql-connector-mysql-cdc</artifactId>
+ <version>${flink.cdc.version}</version>
+ </dependency>
Review Comment:
`flink-sql-connector-*` dependency should be added to `seatunnel-connectors-flink-sql-dist` module
##########
seatunnel-examples/seatunnel-flink-sql-examples/pom.xml:
##########
@@ -95,5 +95,11 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-runtime-web_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
Review Comment:
```suggestion
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-runtime-web_${scala.binary.version}</artifactId>
</dependency>
```
Same the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org