[GitHub] [incubator-superset] john-bodley commented on a change in pull request #7880: [migration] add unique constraint on dashboard_slices table

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #7880: [migration] add unique constraint on dashboard_slices table
URL: https://github.com/apache/incubator-superset/pull/7880#discussion_r305972740
 
 

 ##########
 File path: superset/migrations/versions/190188938582_adding_unique_constraint_on_dashboard_slices_tbl.py
 ##########
 @@ -0,0 +1,102 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Remove duplicated entries in dashboard_slices table and add unique constraint
+
+Revision ID: 190188938582
+Revises: d6ffdf31bdd4
+Create Date: 2019-07-15 12:00:32.267507
+
+"""
+import logging
+
+from alembic import op
+from sqlalchemy import and_, Column, ForeignKey, Integer, Table
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = "190188938582"
+down_revision = "d6ffdf31bdd4"
+
+Base = declarative_base()
+
+
+class DashboardSlices(Base):
+    __tablename__ = "dashboard_slices"
+    id = Column(Integer, primary_key=True)
+    dashboard_id = Column(Integer, ForeignKey("dashboards.id"))
+    slice_id = Column(Integer, ForeignKey("slices.id"))
+
+
+def upgrade():
+    bind = op.get_bind()
+    session = db.Session(bind=bind)
+
+    # find dup records in dashboard_slices tbl
+    dup_records = (
+        session.query(
+            DashboardSlices.dashboard_id,
+            DashboardSlices.slice_id,
+            db.func.count(DashboardSlices.id),
+        )
+        .group_by(DashboardSlices.dashboard_id, DashboardSlices.slice_id)
+        .having(db.func.count(DashboardSlices.id) > 1)
+        .all()
+    )
+
+    # remove dup entries
+    for record in dup_records:
+        print(
+            "remove duplicates from dashboard {} slice {}".format(
+                record.dashboard_id, record.slice_id
+            )
+        )
+
+        ids = [
+            item.id
+            for item in session.query(DashboardSlices.id)
+            .filter(
+                and_(
+                    DashboardSlices.slice_id == record.slice_id,
+                    DashboardSlices.dashboard_id == record.dashboard_id,
+                )
+            )
+            .offset(1)
+        ]
+        session.query(DashboardSlices).filter(DashboardSlices.id.in_(ids)).delete(
+            synchronize_session=False
+        )
+
+    # add unique constraint
+    try:
 
 Review comment:
   @graceguo-supercat if you use the `batch_alter_table` context manager (see [here](https://github.com/apache/incubator-superset/blob/5c58fd18026fa8ab947a8ff5985da469c84a6a6a/superset/migrations/versions/4736ec66ce19_.py#L140) for an example) you shouldn't need to special case the the SQLite logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org