You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/04/20 22:30:50 UTC
Review Request 46452: Clean up stack scripts that refer to
dfs.nameservices to use dfs.internal.nameservices as first option
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46452/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Andrew Onischuk, Sumit Mohanty, and Vitalyi Brodetskyi.
Bugs: AMBARI-15790
https://issues.apache.org/jira/browse/AMBARI-15790
Repository: ambari
Description
-------
Several stack scripts refer to dfs.nameservices and they should be modified to use dfs.internal.nameservices
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 3e957b1
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java b7d2417
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4ce974d
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java b813625
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 2a3d7c7
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java 4f2f02d
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py d3c9009
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py 20d1717
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 95be7ba
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py d6b6225
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 7ad9f39
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py 60f4a74
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py dff9cc0
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py eed2d18
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/files/alert_ha_namenode_health.py a076825
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py e302685
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 5bdc449
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6dd1d84
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java abe7abe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 70e21d3
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java bd3453e
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fd4d0f7
ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start.json 1a6dd39
ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start_dfs_nameservices.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json 178fe7b
Diff: https://reviews.apache.org/r/46452/diff/
Testing
-------
All unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 46452: Clean up stack scripts that refer to
dfs.nameservices to use dfs.internal.nameservices as first option
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46452/#review129803
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On April 20, 2016, 8:30 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46452/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 8:30 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Andrew Onischuk, Sumit Mohanty, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15790
> https://issues.apache.org/jira/browse/AMBARI-15790
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Several stack scripts refer to dfs.nameservices and they should be modified to use dfs.internal.nameservices
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 3e957b1
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java b7d2417
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4ce974d
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java b813625
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 2a3d7c7
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java 4f2f02d
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py d3c9009
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py 20d1717
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 95be7ba
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py d6b6225
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 7ad9f39
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py 60f4a74
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py dff9cc0
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py eed2d18
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/files/alert_ha_namenode_health.py a076825
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py e302685
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 5bdc449
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6dd1d84
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java abe7abe
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 70e21d3
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java bd3453e
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fd4d0f7
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start.json 1a6dd39
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start_dfs_nameservices.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json 178fe7b
>
> Diff: https://reviews.apache.org/r/46452/diff/
>
>
> Testing
> -------
>
> All unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>