You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 17:30:35 UTC

[GitHub] [flink] eskabetxe opened a new pull request, #21223: [FLINK-15462][connectors] Add Trino dialect

eskabetxe opened a new pull request, #21223:
URL: https://github.com/apache/flink/pull/21223

   ## What is the purpose of the change
   
   Add the implementation of the Trino dialect for JDBC connectors
   
   ## Brief change log
   
   Added:
   TrinoDialect
   TrinoDialectFactory
   TrinoRowConverter
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Added integration tests for end-to-end deployment 
     - Some cases already covered with tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] eskabetxe closed pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
eskabetxe closed pull request #21223: [FLINK-15462][connectors] Add Trino dialect
URL: https://github.com/apache/flink/pull/21223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1317675420

   @wanglijie95 Could you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1330775383

   We've now moved the code from the JDBC connector; please re-route this PR to https://github.com/apache/flink-connector-jdbc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1300993207

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "828280a9c4c672af0e67737da302fd095c96108f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "828280a9c4c672af0e67737da302fd095c96108f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 828280a9c4c672af0e67737da302fd095c96108f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] eskabetxe commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
eskabetxe commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1315026977

   @MartijnVisser could you find someone to review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] eskabetxe commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
eskabetxe commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1300995384

   Im working on docs, but it would be cool some review as documentation depends on implementation.
   
   There are two test disabled on TrinoTableSinkITCase, as the Trino connector used (memory) don't allow updates nor deletes, this could be changed using a Trino connector to some database (for example) but complicates the tests, as two containers will be needed (Trino and DB)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] eskabetxe commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

Posted by GitBox <gi...@apache.org>.
eskabetxe commented on PR #21223:
URL: https://github.com/apache/flink/pull/21223#issuecomment-1330880138

   @MartijnVisser , @wanglijie95 
   re-route this PR here https://github.com/apache/flink-connector-jdbc/pull/3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org