You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 21:44:41 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4229: Re-enable TPCH query 6 (#4024)
tustvold opened a new pull request, #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4024
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
#4199 might have resolved this :crossed_fingers: (my laptop is too piddly to confirm locally)
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1584175060
Completed in main :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1411899455
https://github.com/apache/arrow-datafusion/issues/5143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1315981582
Sadly it would appear not :cry:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1315998444
Maybe related to decimal casting rounding issue https://github.com/apache/arrow-rs/issues/1043#issuecomment-1313193183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1411760128
Looks like multiplication is wrong for decimals:
https://github.com/apache/arrow-rs/issues/3645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1315983394
Getting close ... I think there are still some decimal rounding issues to be resolved
```
left: `"Decimal128(Some(12314107823),15,2)"`,
right: `"Decimal128(Some(12314055479),15,2)"`', benchmarks/src/bin/tpch.rs:1208:31
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #4229:
URL: https://github.com/apache/arrow-datafusion/pull/4229#issuecomment-1410544463
Looking at the plan, it looks like the decimal filter values is coming through nicely (though I think that we should see if we can default DataFusion to `parse_float_as_decimal=true` in the parser).
So my guess is that either the multiplication of `lineitem.l_extendedprice * lineitem.l_discount` is causing the error or the `SUM` aggregation is causing it.
```
ProjectionExec: expr=[SUM(lineitem.l_extendedprice * lineitem.l_discount)@0 as revenue], metrics=[output_rows=1, elapsed_compute=250ns, spill_count=0, spilled_bytes=0, mem_used=0]
AggregateExec: mode=Final, gby=[], aggr=[SUM(lineitem.l_extendedprice * lineitem.l_discount)], metrics=[output_rows=1, elapsed_compute=665ns, spill_count=0, spilled_bytes=0, mem_used=0]
CoalescePartitionsExec, metrics=[output_rows=2, elapsed_compute=1µs, spill_count=0, spilled_bytes=0, mem_used=0]
AggregateExec: mode=Partial, gby=[], aggr=[SUM(lineitem.l_extendedprice * lineitem.l_discount)], metrics=[output_rows=2, elapsed_compute=1.550495ms, spill_count=0, spilled_bytes=0, mem_used=0]
CoalesceBatchesExec: target_batch_size=8192, metrics=[output_rows=114160, elapsed_compute=1.228926ms, spill_count=0, spilled_bytes=0, mem_used=0]
FilterExec: l_shipdate@3 >= 8766 AND l_shipdate@3 < 9131 AND l_discount@2 >= Some(5),15,2 AND l_discount@2 <= Some(7),15,2 AND l_quantity@0 < Some(2400),15,2, metrics=[output_rows=114160, elapsed_compute=20.476516ms, spill_count=0, spilled_bytes=0, mem_used=0]
RepartitionExec: partitioning=RoundRobinBatch(2), input_partitions=1, metrics=[fetch_time=1.795540669s, repart_time=1ns, send_time=24.394149ms]
CsvExec: files={1 group: [[Users/danielheres/Code/arrow-datafusion/benchmarks/tpch-dbgen/lineitem.tbl]]}, has_header=false, limit=None, projection=[l_quantity, l_extendedprice, l_discount, l_shipdate], metrics=[output_rows=6001215, elapsed_compute=1ns, spill_count=0, spilled_bytes=0, mem_used=0, time_elapsed_scanning_total=1.819781372s, time_elapsed_scanning_until_data=4.780458ms, time_elapsed_processing=1.79542109s, time_elapsed_opening=59.708µs]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan closed pull request #4229: Re-enable TPCH query 6 (#4024)
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan closed pull request #4229: Re-enable TPCH query 6 (#4024)
URL: https://github.com/apache/arrow-datafusion/pull/4229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org