You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "guiyanakuang (via GitHub)" <gi...@apache.org> on 2023/02/20 03:52:51 UTC

[GitHub] [orc] guiyanakuang opened a new pull request, #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

guiyanakuang opened a new pull request, #1415:
URL: https://github.com/apache/orc/pull/1415

   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If there is a discussion in the mailing list, please add the link.
   -->
   This pr is aimed to cancel old running ci tasks when a pr has a new commit.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   The old tasks were based on outdated code which wasted resources and was pointless. Canceling tasks makes for a more efficient use of resources.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   This pr will be committed multiple times, so we can see if the ci task is executing as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1415:
URL: https://github.com/apache/orc/pull/1415#issuecomment-1436401270

   Also, cc @williamhyun , too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1415:
URL: https://github.com/apache/orc/pull/1415#issuecomment-1436418844

   Thank you for checking. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1415:
URL: https://github.com/apache/orc/pull/1415#discussion_r1111453499


##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   Is it enough to isolate `Pull Request`, @guiyanakuang ?



##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   Is it enough to isolate `Pull Request` only, @guiyanakuang ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun closed pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit
URL: https://github.com/apache/orc/pull/1415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on a diff in pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on code in PR #1415:
URL: https://github.com/apache/orc/pull/1415#discussion_r1111467040


##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   I think it's enough, almost all contributions are currently committed by pull request. 
   
   When it's a pull request event, use the `github.event.number`(issues and PRs share the same incrementing number ID source for new issues/PRs) grouping.
   In other cases use `github.sha` grouping.
   
   Tasks are only treated as concurrent if they are in the same group.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1415:
URL: https://github.com/apache/orc/pull/1415#issuecomment-1436286851

   This pr modifies `build_and_test.yml`, but it doesn't seem to take effect immediately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on a diff in pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on code in PR #1415:
URL: https://github.com/apache/orc/pull/1415#discussion_r1111467040


##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   I think it's enough, almost all contributions are currently committed by pull request. Also when we use to receive other events, we can degrade to grouping using `github.sha`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1415:
URL: https://github.com/apache/orc/pull/1415#issuecomment-1436418064

   ![image](https://user-images.githubusercontent.com/4069905/220032967-8702fbee-ca20-4d26-a627-a598e3d41413.png)
   Looks like it's working well. Thanks for the review and merge, @dongjoon-hyun  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org