You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/07 01:25:30 UTC
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11895
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
IMPALA-7789: [DOCS] Admission status in Impala Shell
Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
---
M docs/topics/impala_admission.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
3 files changed, 97 insertions(+), 113 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/11895/1
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/136/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 01:35:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:51:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/137/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 2: Code-Review+1
Will let Bikram do the final +2 since he had comments.
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:34:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@787
PS1, Line 787: node
coordinator
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@824
PS1, Line 824: <codeph>TRUE</codeph>.</p><p>You can start an
nit: You can also
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@829
PS1, Line 829: queuing status, whether the query was queued
: and what was the latest queuing reason.
can you reword this to explicitly mean that the queuing status consists of whether the query was queued and what was the latest queuing reason.
(update here and in the live_summary and live_progress docs)
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 19:30:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 1:
Tim,
The LIVE_PROGRESS and LIVE_SUMMARY are already mentioned in impala_shell_options.html.
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 01:29:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@787
PS1, Line 787: node
> coordinator
Done
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@824
PS1, Line 824: <codeph>TRUE</codeph>.</p><p>You can start an
> nit: You can also
Done
http://gerrit.cloudera.org:8080/#/c/11895/1/docs/topics/impala_admission.xml@829
PS1, Line 829: queuing status, whether the query was queued
: and what was the latest queuing reason.
> can you reword this to explicitly mean that the queuing status consists of
Done
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:23:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
IMPALA-7789: [DOCS] Admission status in Impala Shell
Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Reviewed-on: http://gerrit.cloudera.org:8080/11895
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M docs/topics/impala_admission.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
3 files changed, 100 insertions(+), 113 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, but someone else must approve
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11895
to look at the new patch set (#2).
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
IMPALA-7789: [DOCS] Admission status in Impala Shell
Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
---
M docs/topics/impala_admission.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
3 files changed, 100 insertions(+), 113 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/11895/2
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/137/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:27:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7789: [DOCS] Admission status in Impala Shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11895 )
Change subject: IMPALA-7789: [DOCS] Admission status in Impala Shell
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/136/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d788eb716c6a2f7a144ee2d81bbe823f74d16a
Gerrit-Change-Number: 11895
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Nov 2018 01:25:38 +0000
Gerrit-HasComments: No