You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/16 21:39:55 UTC

[GitHub] [arrow] kou commented on a change in pull request #6512: ARROW-8430: [CI] Configure self-hosted runners for Github Actions

kou commented on a change in pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#discussion_r441156336



##########
File path: ci/docker/ubuntu-14.04-cpp.dockerfile
##########
@@ -68,7 +68,7 @@ ENV ARROW_BUILD_TESTS=ON \
     ARROW_WITH_BROTLI=ON \
     ARROW_WITH_BZ2=ON \
     ARROW_WITH_LZ4=ON \
-    ARROW_WITH_OPENSSL=OFF \
+    PARQUET_REQUIRE_ENCRYPTION=OFF \

Review comment:
       Could you sort in alphabetical order?

##########
File path: ci/scripts/cpp_build.sh
##########
@@ -127,7 +127,11 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
       ${CMAKE_ARGS} \
       ${source_dir}
 
-time cmake --build . --target install
+if [ ! -z "${CPP_MAKE_PARALLELISM}" ]; then
+  time cmake --build . --target install -- -j${CPP_MAKE_PARALLELISM}

Review comment:
       Does `CMAKE_BUILD_PARALLEL_LEVEL` not work with Ubuntu 20.04?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org