You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/12/20 16:49:54 UTC

[GitHub] [trafficcontrol] jhg03a commented on a diff in pull request #7258: Add install nodejs line to Dockerfile

jhg03a commented on code in PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258#discussion_r1053533506


##########
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile:
##########
@@ -48,6 +48,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
 FROM os-dependencies AS node-dependencies
 # Download and install node
 RUN curl -sL https://rpm.nodesource.com/setup_18.x | bash -
+RUN dnf install -y nodejs

Review Comment:
   This should use yum rather than dnf for Centos7 backward compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org