[GitHub] [inlong] healchow commented on a diff in pull request #8344: [INLONG-8343][Dashboard] Increase the length of the field for creating MySQL varchar types to 16383

["healchow (via GitHub)" <gi...@apache.org>]

healchow commented on code in PR #8344:
URL: https://github.com/apache/inlong/pull/8344#discussion_r1244589273


##########
inlong-dashboard/src/plugins/sinks/defaults/MySQL.ts:
##########
@@ -47,7 +47,7 @@ const fieldTypesConf = {
   TIME: () => '',
   DATETIME: () => '',
   CHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
-  VARCHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
+  VARCHAR: (m, d) => (1 <= m && m <= 16383 ? '' : '1<=M<=16383'),

Review Comment:
   It seems that the maximum length of MySQL's varchar type is 65535?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org