first_time variable in subversion/libsvn_fs_fs/fs_fs.c

["Henderson, Michael D" <mi...@lmco.com>]

I don't know if it's appropriate to ask this here, but I'm looking at subversion/libsvn_fs_fs/fs_fs.c from r9649, in the hash_read function, and I don't understand the first_time variable. It looks like it's initialized to 1, then almost immediately set to 0 in the while loop and not used anywhere else. The comment on line 79 seems to imply that the variable should be used in the surrounding if statement.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: first_time variable in subversion/libsvn_fs_fs/fs_fs.c

[Josh Pieper <jj...@pobox.com>]

Henderson, Michael D wrote:
> I don't know if it's appropriate to ask this here, but I'm looking
> at subversion/libsvn_fs_fs/fs_fs.c from r9649, in the hash_read
> function, and I don't understand the first_time variable. It looks
> like it's initialized to 1, then almost immediately set to 0 in the
> while loop and not used anywhere else. The comment on line 79 seems
> to imply that the variable should be used in the surrounding if
> statement.

This is the exactly correct place to mention this, and yes, first_time
should be used in the conditional.  This hash_read function was copied
from elsewhere, I must have accidentally removed that clause when I
was converting it to read from a stream.  No dire consequences, it
will just incorrectly not return an error upon an unexpected end of
file.  I will fix it shortly.

Thanks!
Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: first_time variable in subversion/libsvn_fs_fs/fs_fs.c

[Josh Pieper <jj...@pobox.com>]

Henderson, Michael D wrote:
> I don't know if it's appropriate to ask this here, but I'm looking
> at subversion/libsvn_fs_fs/fs_fs.c from r9649, in the hash_read
> function, and I don't understand the first_time variable. It looks
> like it's initialized to 1, then almost immediately set to 0 in the
> while loop and not used anywhere else. The comment on line 79 seems
> to imply that the variable should be used in the surrounding if
> statement.

Fixed in r9661.

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org