You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/08 11:48:43 UTC

[GitHub] janpio commented on a change in pull request #124: CB-10893: (android) Allow setting status bar color on Android splashscreen

janpio commented on a change in pull request #124: CB-10893: (android) Allow setting status bar color on Android splashscreen
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910720
 
 

 ##########
 File path: src/android/SplashScreen.java
 ##########
 @@ -307,12 +310,29 @@ public void run() {
 
                 // Create and show the dialog
                 splashDialog = new Dialog(context, android.R.style.Theme_Translucent_NoTitleBar);
-                // check to see if the splash screen should be full screen
+                splashWindow = splashDialog.getWindow();
+		// check to see if the splash screen should be full screen
 
 Review comment:
   fix indentation here please (space instead of tabs)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org