You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/19 15:29:30 UTC
[GitHub] [nifi] greyp9 opened a new pull request #5675: NIFI-9586 - investigate CI failures
greyp9 opened a new pull request #5675:
URL: https://github.com/apache/nifi/pull/5675
#### Description of PR
- poll CI machine before and after build for disk space availability
- preserve surefire test output on build failure for analysis (retain for three days)
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a change in pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
greyp9 commented on a change in pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#discussion_r787941095
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -93,6 +94,17 @@ jobs:
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROFILES }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-ubuntu-en
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
Review comment:
This is actually good. Now we know that there is no issue with the test itself, but rather with the maven invocation of surefire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#issuecomment-1016815687
All the goodness. Thanks Paul and David!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#discussion_r787873482
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -93,6 +94,17 @@ jobs:
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROFILES }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-ubuntu-en
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
Review comment:
Unfortunately it looks like this does not pull any files for the current failure on JDK 11, so perhaps capturing some other output may be helpful.
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -191,3 +216,14 @@ jobs:
run: >-
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-windows-fr
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
+ - name: System Information (after)
+ run: df
Review comment:
Will this command work on Windows?
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -93,6 +94,17 @@ jobs:
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROFILES }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-ubuntu-en
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
+ - name: System Information (after)
Review comment:
It is probably worth renaming this to Disk Usage or something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5675:
URL: https://github.com/apache/nifi/pull/5675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a change in pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
greyp9 commented on a change in pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#discussion_r787946258
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -191,3 +216,14 @@ jobs:
run: >-
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-windows-fr
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
+ - name: System Information (after)
+ run: df
Review comment:
Yes. Here is a sample:
```
Filesystem 1K-blocks Used Available Use% Mounted on
C:/Program Files/Git 267921404 177176668 90744736 67% /
D: 14678012 1903272 12774740 13% /d
Filesystem 1K-blocks Used Available Use% Mounted on
C:/Program Files/Git 267921404 180273952 87647452 68% /
D: 14678012 12950624 1727388 89% /d
```
The first output is before a branch build, the second is from afterwards.
It looks like there is an issue with disk space availability that might need to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a change in pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
greyp9 commented on a change in pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#discussion_r787946258
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -191,3 +216,14 @@ jobs:
run: >-
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-windows-fr
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
+ - name: System Information (after)
+ run: df
Review comment:
Yes. Here is a sample:
```
Filesystem 1K-blocks Used Available Use% Mounted on
C:/Program Files/Git 267921404 177176668 90744736 67% /
D: 14678012 1903272 12774740 13% /d
Filesystem 1K-blocks Used Available Use% Mounted on
C:/Program Files/Git 267921404 180273952 87647452 68% /
D: 14678012 12950624 1727388 89% /d
```
It looks like there is an issue with disk space availability that might need to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a change in pull request #5675: NIFI-9586 - investigate CI failures
Posted by GitBox <gi...@apache.org>.
greyp9 commented on a change in pull request #5675:
URL: https://github.com/apache/nifi/pull/5675#discussion_r787943791
##########
File path: .github/workflows/ci-workflow.yml
##########
@@ -93,6 +94,17 @@ jobs:
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_PROFILES }}
${{ env.MAVEN_PROJECTS }}
+ - name: upload-on-failure
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports-ubuntu-en
+ path: |
+ ./**/target/surefire-reports/*.txt
+ ./**/target/surefire-reports/*.xml
+ retention-days: 3
+ if: failure()
+ - name: System Information (after)
Review comment:
I chose this for symmetry with the preceding "System Information" label, which collects data before the build. My thought was that there might be other non-disk information we might also want to collect after the build. But open to a different name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org