You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/04 05:53:42 UTC
[GitHub] [dolphinscheduler] fuchanghai opened a new issue, #10760: [Feature][dolphinscheduler-api] Some variables are redundant
fuchanghai opened a new issue, #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Subclasses that inherit BaseServiceImpl and have the resourcePermissionCheckService attribute should remove this attribute in the subclass. Because this attribute already exists in the BaseServiceImpl class (eg:DataSourceServiceImpl ,ProjectServiceImpl)
### Use case
remove the resourcePermissionCheckService attribute
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] WangJPLeo commented on issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
WangJPLeo commented on issue #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760#issuecomment-1189962456
> PTAL @WangJPLeo
Yes, there are methods userOwnedResourceIdsAcquisition and functionDisabled directly used in subclasses. These should be used uniformly in BaseServiceImpl. This is a very standardized transformation, one thing to note is the use of the Logger parameter in the corresponding ut. @caishunfeng @fuchanghai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS closed issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
SbloodyS closed issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
URL: https://github.com/apache/dolphinscheduler/issues/10760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760#issuecomment-1173380242
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760#issuecomment-1189942416
PTAL @WangJPLeo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760#issuecomment-1193824204
@SbloodyS There is some checkstyle warning in the involved subclasses, can I handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #10760: [Feature][dolphinscheduler-api] Some variables are redundant
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #10760:
URL: https://github.com/apache/dolphinscheduler/issues/10760#issuecomment-1192153118
@caishunfeng I still see the discussion tag. I will change it first and wait for you to confirm before PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org